Fix ES module deserialization#942
Merged
bnoordhuis merged 1 commit intoquickjs-ng:masterfrom Mar 6, 2025
Merged
Conversation
saghul
approved these changes
Mar 3, 2025
Contributor
saghul
left a comment
There was a problem hiding this comment.
Something tells me this might backfire, but I don't have a better suggestion 😅 Maybe leave a comment in the code?
A module's imports are not serialized along with the module itself and that left the deserialized module with dangling references. Fix that by checking the module cache first, the module loader second. A glaring problem with cache checking is that the cached module doesn't have to be the module it was at the time of serialization. Why not call out to the module loader right away? Because then a module can get loaded twice and that's arguably even worse. The alternative of serializing modules transitively doesn't work for C modules and is also prone to loading the same module twice. Fixes: quickjs-ng#913
Contributor
Author
|
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A module's imports are not serialized along with the module itself and that left the deserialized module with dangling references. Fix that by checking the module cache first, the module loader second.
A glaring problem with cache checking is that the cached module doesn't have to be the module it was at the time of serialization.
Why not call out to the module loader right away? Because then a module can get loaded twice and that's arguably even worse.
The alternative of serializing modules transitively doesn't work for C modules and is also prone to loading the same module twice.
Fixes: #913
As you can probably tell, I don't think it's a great fix, merely the least terrible.