Conversation
Closed
bnoordhuis
reviewed
Feb 6, 2025
Comment on lines
+6768
to
+6770
| if (JS_ToFloat64(ctx, &d, ctx->error_stack_trace_limit) < 0) { | ||
| // Ignore error since it sets d to NAN anyway. | ||
| } |
Contributor
There was a problem hiding this comment.
Maybe better:
Suggested change
| if (JS_ToFloat64(ctx, &d, ctx->error_stack_trace_limit) < 0) { | |
| // Ignore error since it sets d to NAN anyway. | |
| } | |
| // Ignore error since it sets d to NAN anyway. | |
| // coverity[check_return] | |
| JS_ToFloat64(ctx, &d, ctx->error_stack_trace_limit); |
Clearer and, from what I remember from node's coverity scans, "using" the value like you do here doesn't work.
Contributor
Author
There was a problem hiding this comment.
If that works, great!
228596f to
863a6bd
Compare
Contributor
Author
|
A quick github search suggests that is indeed the right way to silence it. Updated! |
Contributor
|
Looks good to me |
Collaborator
|
In case an exception is thrown by |
Contributor
Author
We restore the exception right after the dance, so it will be discarded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #890