Merged
Conversation
Contributor
Author
|
@bnoordhuis PTAL, this is my first foray into the parser 😅 |
bnoordhuis
approved these changes
Jan 24, 2025
| static int js_parse_destructuring_element(JSParseState *s, int tok, int is_arg, | ||
| int hasval, int has_ellipsis, | ||
| bool allow_initializer) | ||
| bool allow_initializer, bool export_flag) |
Contributor
There was a problem hiding this comment.
A suggestion for a follow-up PR: replace these 5 booleans with a flags argument. Call sites are IMO more legible as frob(HasArg|HasVal|HasEllipsis|AllowInitializer|ExportFlag) than frob(true,false,false,true,true)
(I suppose that, although its name suggests it's a boolean, has_ellipsis is actually a tri-state. The others are booleans though.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: bellard/quickjs#382