Fix uncatchable error inside a promise (#810)#811
Fix uncatchable error inside a promise (#810)#811saghul merged 1 commit intoquickjs-ng:masterfrom laishere:master
Conversation
|
It would be good to have a test for this. |
|
How to run all the tests? @saghul I just ran run-test262.exe tests.confResult: 0/29 errors, 3 excluded Cannot run test262.conf. BTW, I should add my test.js to tests directory right? |
|
This wouldn't be a 262 test, so yeah adding it to the tests/ directory is the way. |
|
I just realized that we need an interrupt handler to test it. So I can't do it in pure js. So would need a separate test or modify run-test262.c |
|
Yes it would likely need to be its own C file with the simplified test. |
|
Should I add Makefile and CMakeLists.txt target for this test? @saghul |
|
CMake should be the only requirement, since it shouldn't have EXCLUDE_FROM_ALL |
|
Looking good! Can you pl run the test from the CI files? Building it won't make it run. |
|
Sure! |
|
Updated. |
|
Can you please add it to (some of) the windows targets? |
|
No problem, I am working on it now! |
|
Updated. |
saghul
left a comment
There was a problem hiding this comment.
LGTM nice work! @bnoordhuis can you have a quick look?
|
Updated. |
Fix issue #810