Skip to content

Build backtrace in JS_NewError#809

Merged
saghul merged 1 commit intomasterfrom
new-error-backtrace
Jan 10, 2025
Merged

Build backtrace in JS_NewError#809
saghul merged 1 commit intomasterfrom
new-error-backtrace

Conversation

@saghul
Copy link
Copy Markdown
Contributor

@saghul saghul commented Jan 9, 2025

Behave similarly to the constructor since it's expected that a backtrace be created.

Behave similarly to the constructor since it's expected that a backtrace
be created.
@saghul saghul requested a review from bnoordhuis January 9, 2025 21:59
@saghul
Copy link
Copy Markdown
Contributor Author

saghul commented Jan 9, 2025

@bnoordhuis PTAL. Not fixing a specific bug here, just noticed while going through some code. WDYT?

Copy link
Copy Markdown
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't hurt, I think?

@saghul saghul merged commit c8153fe into master Jan 10, 2025
@saghul saghul deleted the new-error-backtrace branch January 10, 2025 09:10
@saghul
Copy link
Copy Markdown
Contributor Author

saghul commented Jan 10, 2025

Hopefully not :-P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants