Of course!

For my curiosity, in https://github.com/godotjs/GodotJS?tab=readme-ov-file#supported-platforms you list quickjs.impl as mostly complete but quickjs.impl (quickjs-ng) as predominantly incomplete. Why is that? It should be a drop-in replacement, right?

For my curiosity, in https://github.com/godotjs/GodotJS?tab=readme-ov-file#supported-platforms you list quickjs.impl as mostly complete but quickjs.impl (quickjs-ng) as predominantly incomplete. Why is that? It should be a drop-in replacement, right?

Ah, there are some test works on my side (check the built godot app works properly on each platform). QuickJS-NG is fantastic to use. For windows, I'll add comments in README right away, about the requirement of clang compiler to build with QuickJS-NG (my current environment on windows is MSVC, and it fails to compile). I've tested without errors on Linux/Android today.

BTW, may I submit another PR to add two functions JS_IsMap and JS_IsPromise (very simple, like the JS_IsArrayBuffer which already exists)? Otherwise, the only way I could use is JS_IsInstanceOf which seems relatively more expensive.

Those PRs would be welcome!

About the compiler: we support MSVC >= 2019 out of the box. Can you share details on what compilation issues you've ran into?

I'm using MSVC 2022, it complains tons of errors about atomics, such as vcruntime_c11_stdatomic.h(36): Error C2061 : syntax error: identifier 'atomic_bool' . I tried the compiler option /experimental:c11atomics but it doesn't help. I'll investigate into it tomorrow, and report an issue with more details if it's not resolved on my side.

We use that flag in the project. Do you use CMake to compile the QuickJS target or something else?

Godot uses scons. I figured it out after reading the cmake file. /std:c11 was missing in my scons build script 😂.