Skip to content

Fix comment of JS_NewClassID#784

Merged
bnoordhuis merged 1 commit intoquickjs-ng:masterfrom
gschwind:pr-fix-js-newclassid-comment
Jan 5, 2025
Merged

Fix comment of JS_NewClassID#784
bnoordhuis merged 1 commit intoquickjs-ng:masterfrom
gschwind:pr-fix-js-newclassid-comment

Conversation

@gschwind
Copy link
Copy Markdown
Contributor

@gschwind gschwind commented Jan 4, 2025

The comment of the function JS_NewClassID is wrong. This patch fix it.

Best regards

Comment thread quickjs.c Outdated
/* JSClass support */

/* a new class ID is allocated if *pclass_id != 0 */
/* a new class ID is allocated if *pclass_id == 0, otherwise *pclass_id is left inchanged */
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"unchanged"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, updated

@gschwind gschwind force-pushed the pr-fix-js-newclassid-comment branch from 59b77d6 to 68e94ee Compare January 4, 2025 15:13
@bnoordhuis bnoordhuis merged commit 1b957f7 into quickjs-ng:master Jan 5, 2025
@gschwind gschwind deleted the pr-fix-js-newclassid-comment branch January 6, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants