Add option to use clang's MSVC ABI#729
Merged
saghul merged 5 commits intoquickjs-ng:masterfrom Dec 4, 2024
Oliver-makes-code:master
Merged
Add option to use clang's MSVC ABI#729saghul merged 5 commits intoquickjs-ng:masterfrom Oliver-makes-code:master
saghul merged 5 commits intoquickjs-ng:masterfrom
Oliver-makes-code:master
Conversation
Contributor
|
Can't we detect this in CMake? |
Contributor
Author
|
You can detect it, but since it's a generally niche use-case, it didn't seem worth the extra complexity to me. |
Contributor
|
I politely disagree :-) Let's see how much it really takes to get this right. Would this work? |
Contributor
The counterargument is that build options are really hard to remove once people start depending on them, so adding them should be done sparingly. |
Contributor
Author
This could work |
Contributor
|
Can you give it a try? If it works we could just land that. |
Contributor
Author
|
It seems to work |
saghul
reviewed
Dec 3, 2024
saghul
reviewed
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #728.
Adds
QJS_CLANG_MSVC_ABIoption, defaulted toOFF. It doesn't linklibmif it'sON.I opted to have it be an option, because implementing behavior to check the clang target would add too much complexity.