Conversation
|
@bnoordhuis PTAL, Tests pass locally, this should be good for review! Once this one lands I expect the rest to be simple to add, I scratched my head a few times while working on this, but I feel like I got a much better understanding as to how iterators work internally! |
|
Green! |
| abort(); | ||
| } | ||
|
|
||
| done: |
There was a problem hiding this comment.
I wonder if we should free the wrapped iterator after we are done with it?
There was a problem hiding this comment.
At terminal state, when the helper won't touch the wrapped iterator anymore? I would assume so.
Probably doesn't matter from a correctness perspective (not observable), only for efficiency.
There was a problem hiding this comment.
👍 I'll leave this for the end because I suspect some simplification will happen once all remaining methods are in.
| abort(); | ||
| } | ||
|
|
||
| done: |
There was a problem hiding this comment.
At terminal state, when the helper won't touch the wrapped iterator anymore? I would assume so.
Probably doesn't matter from a correctness perspective (not observable), only for efficiency.
Includes the scaffold for other iterator helper methods that require an Iterator Helper object.
6fdc48a to
92cd712
Compare
Includes the scaffold for other iterator helper methods that require an Iterator Helper object.