Skip to content

Don't automatically update test262 submodule#663

Merged
saghul merged 4 commits intoquickjs-ng:masterfrom
richarddd:disable-test262-submodule-update
Nov 8, 2024
Merged

Don't automatically update test262 submodule#663
saghul merged 4 commits intoquickjs-ng:masterfrom
richarddd:disable-test262-submodule-update

Conversation

@richarddd
Copy link
Copy Markdown
Contributor

When quickjs-ng now is used a dependency of rquickjs, cargo automatically pulls in all submodules when checking out sources. This causes errors on windows hosts where the filepath becomes to long:

path too long: 'C:/Users/runneradmin/.cargo/git/checkouts/rquickjs-c5d9b5f474075f2d/9e0229a/sys/quickjs/test262/test/built-ins/Object/seal/object-seal-configurable-attribute-of-own-data-property-of-o-is-set-from-true-to-false-and-other-attributes-of-the-property-are-unaltered.js'; class=Filesystem (30)

@saghul
Copy link
Copy Markdown
Contributor

saghul commented Nov 8, 2024

I guess our CI doesn't download it automagically now. Can you fix that please? LGTM otherwise.

@saghul saghul merged commit cd2947b into quickjs-ng:master Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants