Make sure an ArrayBuffer never has a NULL data pointer#1437
Merged
Conversation
This reverts 6734b76. I was wrong on the direction of that fix. The reulting API is very un-ergonomic: one needs to check for exceptions in case of a NULL return since it would've been legit, and creaes an asymetry with string APIs that return a pointer, but NULL on error.
Contributor
Author
|
@bnoordhuis PTAL. I had tunnel vision here, and only realized this was wrong after trying to make it work in txiki.js: saghul/txiki.js@9f0dda2 yeah, bad idea... |
bnoordhuis
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts 6734b76.
I was wrong on the direction of that fix. The reulting API is very
un-ergonomic: one needs to check for exceptions in case of a NULL return
since it would've been legit, and creaes an asymetry with string APIs
that return a pointer, but NULL on error.