Skip to content

Fix native Big Endian build#1418

Merged
saghul merged 1 commit intomasterfrom
fix-be
Mar 21, 2026
Merged

Fix native Big Endian build#1418
saghul merged 1 commit intomasterfrom
fix-be

Conversation

@saghul
Copy link
Copy Markdown
Contributor

@saghul saghul commented Mar 21, 2026

Store bytecode checksum in native endianness.

Fixes: #1417

@saghul
Fix native Big Endian build
dca6f73 
Store bytecode checksum in native endianness.

Fixes: #1417
@saghul saghul marked this pull request as ready for review March 21, 2026 15:34
@saghul
Copy link
Copy Markdown
Contributor Author

saghul commented Mar 21, 2026

This one is ready to go:

/src/quickjs # uname -a
Linux 8b3147e22faa 6.8.0-64-generic #67-Ubuntu SMP PREEMPT_DYNAMIC Sun Jun 15 20:23:40 UTC 2025 s390x Linux
/src/quickjs # ./build/qjs --include ./stanc.js
QuickJS-ng - Type ".help" for help
qjs > stanc("model_name","data{}")
{
  result: '// Code generated by stanc v2.38.0-85-g582ade1\n#include <stan/model/model_head...',
  warnings: []
}
qjs >

@saghul saghul requested a review from bnoordhuis March 21, 2026 15:35
@saghul saghul merged commit fa2f060 into master Mar 21, 2026
122 checks passed
@saghul saghul deleted the fix-be branch March 21, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Native BE compatibility

2 participants

@saghul @bnoordhuis