Don't set -Werror by default#1340
Merged
bnoordhuis merged 1 commit intoquickjs-ng:masterfrom Feb 10, 2026
Merged
Conversation
It's annoying for downstream users when they don't use the exact same compiler as we do because any random new (or old) compiler warning breaks the build. Only set the flag on CI or when explicitly requested with the new QJS_BUILD_WERROR cmake option. Fixes: quickjs-ng#1339
saghul
approved these changes
Feb 10, 2026
Contributor
|
LGTM. What I was thinking was something like https://cmake.org/cmake/help/latest/variable/PROJECT_IS_TOP_LEVEL.html and then we'd need no option, we can just have it always on if we are the top level project. No strong opinion though! |
Contributor
Author
|
It's kind of attractive (no new flag) but it wouldn't have fixed #1333. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's annoying for downstream users when they don't use the exact same compiler as we do because any random new (or old) compiler warning breaks the build.
Only set the flag on CI or when explicitly requested with the new QJS_BUILD_WERROR cmake option.
Fixes: #1339