Remove force_inline macro#1335
Merged
bnoordhuis merged 1 commit intoquickjs-ng:masterfrom Feb 9, 2026
Merged
Conversation
Don't second-guess the compiler, leave it up to the compiler when or when not to inline.
saghul
approved these changes
Feb 9, 2026
Contributor
I'd apply the same "no second guessing" principle. Maybe throw a quick benchmark to make sure we are not hitting any pathological case, out of abundant caution? |
Contributor
Author
|
Yep, sounds good, will do (though not today.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't second-guess the compiler, leave it up to the compiler when or when not to inline.
@saghul what are your thoughts on the
no_inlinemacro?