Conversation
Contributor
Author
|
No idea why TCC would fail... @bnoordhuis you likely have it ready to go, mind giving it a try? |
Contributor
|
Atomic ops are disabled for tcc because they get miscompiled in (not so) recent versions, see 4871290. As a workaround, add something like below to tests.conf: Then add a magic comment to the test file: |
Contributor
|
General observation (cc @Mcsky23): ideally tests for this get submitted to https://github.com/tc39/test262 because then it trickles down to all JS engines. |
Contributor
Author
Got it, will do! |
bnoordhuis
approved these changes
Jan 6, 2026
c170fef to
55b5128
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1301
Fixes: #1302