Fix leak in JS_NewArrayFrom at OOM#1176
Merged
bnoordhuis merged 2 commits intoquickjs-ng:masterfrom Oct 1, 2025
Merged
Conversation
If it "takes ownership of |values|", it must also free them on exception.
bnoordhuis
approved these changes
Sep 30, 2025
Contributor
Author
|
Ah but that adds a double free to OP_array_from doesn't it... |
Contributor
|
That's a good point but, untested, I think you can just do this: diff --git a/quickjs.c b/quickjs.c
index 63786a3..ecdcdda 100644
--- a/quickjs.c
+++ b/quickjs.c
@@ -16636,9 +16636,9 @@ static JSValue JS_CallInternal(JSContext *caller_ctx, JSValueConst func_obj,
pc += 2;
call_argv = sp - call_argc;
ret_val = JS_NewArrayFrom(ctx, call_argc, call_argv);
+ sp -= call_argc;
if (unlikely(JS_IsException(ret_val)))
goto exception;
- sp -= call_argc;
*sp++ = ret_val;
}
BREAK; |
Contributor
Author
|
Right, that should work, thanks. |
saghul
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If it "takes ownership of |values|", it must also free them on exception.