Improve handling of set-like .size properties#1171
Merged
bnoordhuis merged 1 commit intoquickjs-ng:masterfrom Sep 29, 2025
Merged
Improve handling of set-like .size properties#1171bnoordhuis merged 1 commit intoquickjs-ng:masterfrom
bnoordhuis merged 1 commit intoquickjs-ng:masterfrom
Conversation
saghul
approved these changes
Sep 28, 2025
test262 doesn't test it but the spec mandates that negative .size properties should result in a RangeError being raised, and that is indeed what V8 and SpiderMonkey do. Now we do, too. Adjust for another quirk, which is that Infinity is a legal size, and, more generally, that sizes > Number.MAX_SAFE_INTEGER are not illegal - which is okay, because the size is not actually used for anything, because of course it isn't.
93d4877 to
f526708
Compare
Contributor
|
Your fix for .size is still not correct because it should be converted to integer before the < 0 test. You should run the test262/staging tests where many such corner cases are tested. |
Contributor
Author
|
I'll wait for those tests to get promoted out of staging. IMO it's not fruitful to spend time on staging tests, they have a habit of disappearing again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test262 doesn't test it but the spec mandates that negative .size
properties should result in a RangeError being raised, and that is
indeed what V8 and SpiderMonkey do. Now we do, too.
Adjust for another quirk, which is that Infinity is a legal size,
and, more generally, that sizes > Number.MAX_SAFE_INTEGER are not
illegal - which is okay, because the size is not actually used for
anything, because of course it isn't.
First commit is #1169.