Fix String.prototype match/split/etc. methods#1064
Merged
bnoordhuis merged 1 commit intoquickjs-ng:masterfrom May 22, 2025
Merged
Fix String.prototype match/split/etc. methods#1064bnoordhuis merged 1 commit intoquickjs-ng:masterfrom
bnoordhuis merged 1 commit intoquickjs-ng:masterfrom
Conversation
test262's expectation is that String methods don't try to look up well-known symbols like Symbol.match and Symbol.split on primitive values, even when those values have prototypes that do contain the symbol. Make it so.
saghul
approved these changes
May 22, 2025
Contributor
saghul
left a comment
There was a problem hiding this comment.
Nice bunch of failures removed!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test262's expectation is that String methods don't try to look up well-known symbols like Symbol.match and Symbol.split on primitive values, even when those values have prototypes that do contain the symbol. Make it so.