Support for AVX MSVC builds#1054
Merged
saghul merged 1 commit intoquickjs-ng:masterfrom May 26, 2025
mekhontsev:master
Merged
Conversation
To have <immintrin.h> we need to check the __SSE2__ and __AVX__ macros.
Contributor
|
What problem did you run into? |
Contributor
Author
|
When I tried to compile xsum.c with AVX2 enabled (latest MSVC), I got the missing definitions from immintrin.h |
Contributor
|
IS that something we could add to the CI? |
Contributor
Author
|
Since QuickJS already uses SSE/AVX, it would be better to have at least one CMake target to check this code path... |
Contributor
|
I don't have much experience in that myself 😅 What do you have in mind? |
Contributor
Author
|
At the first stage we can just add the simplest check (something like): if(MSVC)
add_library(xsum xsum.c)
target_compile_options(xsum PRIVATE /arch:AVX2)
endif() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To have <immintrin.h>, we need to check the SSE2 and AVX macros.