Conversation
Contributor
saghul
commented
May 1, 2025
bnoordhuis
approved these changes
May 2, 2025
Contributor
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM although I have a mild preference for writing it out as a char array so no compiler-specific annotations are necessary.
(It's what I did in 6e43400 but apparently I overlooked this one.)
|
|
||
| /* 2 <= base <= 36 */ | ||
| char const digits36[36] = { | ||
| char const digits36[36] JS_NONSTRING_ATTR = { |
Contributor
There was a problem hiding this comment.
The attribute isn't necessary here, right?
Contributor
Author
|
Oh I see. That does look better. I'll align it to match your change. |
```
quickjs.c:11727:32: error: initializer-string for array of 'char' truncates NUL terminator but destination lacks 'nonstring' attribute (37 chars into 36 available) [-Werror=unterminated-string-initialization]
11727 | static char const digits[36] = "0123456789abcdefghijklmnopqrstuvwxyz";
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.