Update test262#1035
Merged
bnoordhuis merged 1 commit intoquickjs-ng:masterfrom Apr 25, 2025
Merged
Conversation
|
I am concerned that the execution conditions for test262 are different between the bellard version and the NG version. I expect the NG version to include the bellard version in the test cases.
In addition, it seems that the bellard version has recently started supporting staging test cases. What do you think about the NG version? |
saghul
approved these changes
Apr 25, 2025
Contributor
saghul
left a comment
There was a problem hiding this comment.
Damn that's some failures to work through! 😅
Contributor
Author
@saghul It looks like a lot but most are variations of two bugs, I think. Fix the bug, fix a slew of failing tests.
@nabetti1720 We've done that in the past but half the time upstream staging stuff gets removed again and then it's just wasted effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.