Skip to content

Use 32bit limbs for BigInt implementation#1008

Merged
saghul merged 2 commits intomasterfrom
simplify-bigint
Apr 3, 2025
Merged

Use 32bit limbs for BigInt implementation#1008
saghul merged 2 commits intomasterfrom
simplify-bigint

Conversation

@saghul
Copy link
Copy Markdown
Contributor

@saghul saghul commented Apr 3, 2025

It's simpler and compatible with all platforms.

It's simpler and compatible with all platforms.
Comment thread quickjs.c
@saghul
Copy link
Copy Markdown
Contributor Author

saghul commented Apr 3, 2025

It thinks there is a leak :-/

./build/qjs -D0x4000 -I test262/harness/assert.js test262/test/language/expressions/unary-plus/bigint-throws.js
Memory leak: 16 bytes lost in 1 block

@saghul saghul requested a review from bnoordhuis April 3, 2025 08:19
@saghul saghul marked this pull request as ready for review April 3, 2025 08:19
Comment thread quickjs.c
@saghul saghul merged commit 68d4017 into master Apr 3, 2025
238 of 239 checks passed
@saghul saghul deleted the simplify-bigint branch April 3, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants