Skip to content

Add pointer cast magic to avoid pedantic warnings with gcc-13#1001

Merged
saghul merged 1 commit intoquickjs-ng:masterfrom
Gottox:improve/fix-pedantic
Mar 31, 2025
Merged

Add pointer cast magic to avoid pedantic warnings with gcc-13#1001
saghul merged 1 commit intoquickjs-ng:masterfrom
Gottox:improve/fix-pedantic

Conversation

@Gottox
Copy link
Copy Markdown
Contributor

@Gottox Gottox commented Mar 27, 2025

The same trick is used on line 689, so I'm considering it reasonable to do the same for js_os_exec_once_init.

// ...
// line 689:
    *(void **) (&init) = dlsym(hd, "js_init_module");
// ...

@Gottox
Add pointer cast magic to avoid pedantic warnings with gcc-13
1c87b48 
The same trick is used on line 689, so I'm considering it reasonable to
do the same for js_os_exec_once_init.
@Gottox
Copy link
Copy Markdown
Contributor Author

Gottox commented Mar 27, 2025 •
edited
Loading

Would it make sense to run the CI with -Wpedantic -Werror? - afaics quickjs-ng is handling pedantic just fine after this PR with clang-17/gcc-13.

@saghul
Copy link
Copy Markdown
Contributor

saghul commented Mar 27, 2025

Let's give it a try!

@saghul saghul merged commit fc31927 into quickjs-ng:master Mar 31, 2025
128 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saghul saghul saghul approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Gottox @saghul