Skip to content

cannot update submodules #6

@phuslu

Description

@phuslu

I ran into following issue when try update submodules

$ git clone https://github.com/marten-seemann/qpack
$ cd qpack
$ git submodule update --init --recursive
Submodule 'integrationtests/interop/qifs' (git@github.com:qpackers/qifs.git) registered for path 'integrationtests/interop/qifs'
Cloning into 'integrationtests/interop/qifs'...
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
Clone of 'git@github.com:qpackers/qifs.git' into submodule path 'integrationtests/interop/qifs' failed

And I found use https scheme could cure this problem.

diff --git a/.gitmodules b/.gitmodules
index 10a7000..5ac16f0 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,3 +1,3 @@
 [submodule "integrationtests/interop/qifs"]
        path = integrationtests/interop/qifs
-       url = git@github.com:qpackers/qifs.git
+       url = https://github.com/qpackers/qifs.git

So Is reasonable apply this change?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions