Skip to content

fix(sql): fix 'Invalid column' column error for columns used in non-equality join conditions #3912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ideoma merged 3 commits into from
Nov 7, 2023
Merged

fix(sql): fix 'Invalid column' column error for columns used in non-equality join conditions #3912

ideoma merged 3 commits into from
Nov 7, 2023

Conversation

@bziobrowski
Copy link
Contributor

@bziobrowski bziobrowski commented Nov 3, 2023

Fixes #3733

PR fixes propagation of non-equality join condition columns .
Example:

create table test (event int, created timestamp);

SELECT count(*)
FROM test as T1
JOIN ( SELECT * FROM test ) as T2 ON T1.event < T2.event
JOIN test as T3 ON T2.created = T3.created;

returns invalid column T2.event error because T2.event is pushed to top-most T2 only model.

@jerrinot jerrinot self-requested a review November 6, 2023 14:09
@puzpuzpuz puzpuzpuz changed the title fix(sql): fix 'Invalid column' coumn error for columns used in non-equality join conditions fix(sql): fix 'Invalid column' column error for columns used in non-equality join conditions Nov 7, 2023
@puzpuzpuz puzpuzpuz added Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution labels Nov 7, 2023
@ideoma
Copy link
Collaborator

ideoma commented Nov 7, 2023

[PR Coverage check]

😍 pass : 3 / 3 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/SqlOptimiser.java 3 3 100.00%

@ideoma ideoma merged commit d7e11fe into master Nov 7, 2023
@ideoma ideoma deleted the bz_fix_invalid_column_error branch November 7, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerrinot jerrinot jerrinot approved these changes

Assignees

No one assigned

Labels

Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invalid column error not completely fixed

5 participants

@bziobrowski @ideoma @jerrinot @puzpuzpuz