fix(sql): fix group by performance when selected columns have aliases#3013
Merged
bluestreak01 merged 4 commits intomasterfrom Feb 23, 2023
Merged
fix(sql): fix group by performance when selected columns have aliases#3013bluestreak01 merged 4 commits intomasterfrom
bluestreak01 merged 4 commits intomasterfrom
Conversation
Contributor
|
@puzpuzpuz I haven't started the review yet, but I already have one ask: Please add the idea behind the fix as a PR description. Just a sentence or two explaining why it was slower before and what about this PR makes it faster. Thanks a lot! |
Contributor
Author
Good point. Did my best to describe the changes. See the PR description. |
bluestreak01
approved these changes
Feb 23, 2023
Collaborator
[PR Coverage check]😍 pass : 31 / 40 (77.50%) file detail
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2566
Changes
SelectedRecordCursorFactoryto support page frame when the underlying base factory supports them. This enables vectorization for queries with transitioning query model such asselect s as symbol, count() from x. In such queriesSelectedRecordCursorFactoryis used as an intermediate factory between the upper-level group by factory and lower-levelDataFrameRecordCursorFactory.