Skip to content

fix(ilp): do not modify representation of Long.MIN_VALUE sent over ILP#3011

Merged
bluestreak01 merged 2 commits intomasterfrom
long_min_over_ilp
Feb 24, 2023
Merged

fix(ilp): do not modify representation of Long.MIN_VALUE sent over ILP#3011
bluestreak01 merged 2 commits intomasterfrom
long_min_over_ilp

Conversation

@eugenels
Copy link
Contributor

@eugenels eugenels commented Feb 22, 2023

Fixes #3009

@eugenels eugenels marked this pull request as ready for review February 22, 2023 15:55
@eugenels eugenels requested a review from ideoma February 22, 2023 15:55
@bziobrowski
Copy link
Contributor

Looks fine but could you check if the same error doesn't occur for int null ?

@eugenels
Copy link
Contributor Author

Looks fine but could you check if the same error doesn't occur for int null ?

We only have longColumn(CharSequence name, long value) on the Sender side, so this shouldn't happen for int

Copy link
Contributor

@bziobrowski bziobrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ideoma
Copy link
Collaborator

ideoma commented Feb 24, 2023

[PR Coverage check]

😍 pass : 2 / 2 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/cutlass/line/AbstractLineSender.java 2 2 100.00%

@bluestreak01 bluestreak01 merged commit dfd4ad2 into master Feb 24, 2023
@bluestreak01 bluestreak01 deleted the long_min_over_ilp branch February 24, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot insert Long.MIN_VALUE over line protocol

4 participants