fix(sql): make sure that order by is not ignored by row_number() function#2999
Merged
bluestreak01 merged 3 commits intomasterfrom Feb 20, 2023
Merged
fix(sql): make sure that order by is not ignored by row_number() function#2999bluestreak01 merged 3 commits intomasterfrom
bluestreak01 merged 3 commits intomasterfrom
Conversation
Collaborator
[PR Coverage check]😍 pass : 5 / 5 (100.00%) file detail
|
Contributor
Author
|
The failed mac-other run is due to Maven repos being unreachable to the CI worker. |
jerrinot
approved these changes
Feb 20, 2023
Contributor
jerrinot
left a comment
There was a problem hiding this comment.
the code change looks good.
the PR title is alright too.
Contributor
Author
|
@jerrinot thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2620
Closes #2705
Also fixes an invalid assertion in
ReaderPoolTest#testConcurrentRead().