Skip to content

build(deps): bump ant from 1.10.1 to 1.10.8#242

Merged
ned21 merged 1 commit intomasterfrom
dependabot/maven/org.apache.ant-ant-1.10.8
Oct 13, 2020
Merged

build(deps): bump ant from 1.10.1 to 1.10.8#242
ned21 merged 1 commit intomasterfrom
dependabot/maven/org.apache.ant-ant-1.10.8

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 14, 2020

Bumps ant from 1.10.1 to 1.10.8.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot
build(deps): bump ant from 1.10.1 to 1.10.8
68ff804 
Bumps ant from 1.10.1 to 1.10.8.

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 14, 2020
@hpcugentbot
Copy link

hpcugentbot commented Sep 14, 2020

Can one of the admins verify this patch?

@ned21
Copy link
Contributor

ned21 commented Sep 15, 2020

@hpcugentbot Test this please

@ned21 ned21 modified the milestone: 10.8 Sep 15, 2020
@ned21
Copy link
Contributor

ned21 commented Sep 15, 2020

I can't get to https://jenkins0.ugent.be/job/panc-pr-builder/181/ to see why the build failed. @stdweird ?

@jrha
Copy link
Member

jrha commented Oct 8, 2020

Jenkins pages are also unreachable for me, so I cannot see what the failure is.

@ned21
Copy link
Contributor

ned21 commented Oct 12, 2020

My guess would be that the Jenkins box in Ugent has too old a version of maven. When I run it in a centos7 container with the default maven (3.0.5) I see:

[ERROR] Failed to execute goal com.theoryinpractise:clojure-maven-plugin:1.8.1:compile (compile) on project panc: The plugin com.theoryinpractise:clojure-maven-plugin:1.8.1 requires Maven version 3.3 -> [Help 1]

Although the pom.xml says we've needed at least 3.3.3 for a while.

Do we still need the Jenkins run? Looking at the travis run I see the tests being run so is it sufficient that Travis passes and we can drop the Jenkins check?

[INFO] Running org.quattor.ant.DebugPatternsTest
2509[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 s - in org.quattor.ant.DebugPatternsTest
2510[INFO] 
2511[INFO] Results:
2512[INFO] 
2513[INFO] Tests run: 857, Failures: 0, Errors: 0, Skipped: 0
2514[INFO] 
2515[INFO] 
2516[INFO] --- clojure-maven-plugin:1.8.1:test (test) @ panc ---
2517
2518Testing org.quattor.pan.pan-compiler-test
2519
2520Ran 1 tests containing 1 assertions.
25210 failures, 0 errors.
2522
2523Testing org.quattor.pan.cmd-option-test
2524
2525Ran 10 tests containing 35 assertions.
25260 failures, 0 errors.
2527
2528Testing org.quattor.pan.pan-annotations-test
2529
2530Ran 9 tests containing 34 assertions.
25310 failures, 0 errors.
2532
2533Testing org.quattor.pan.cmd-option-utils-test
2534
2535Ran 6 tests containing 30 assertions.
25360 failures, 0 errors.
2537Tests run: , Assertions: 100, Failures: 0, Errors: 0
2538[INFO]

@jrha
Copy link
Member

jrha commented Oct 12, 2020

Dropping the Jenkins tests is fine by me.

@ned21
Copy link
Contributor

ned21 commented Oct 13, 2020

Just realised there is no status check on this repo, we just need a review and we can ignore Jenkins.

Jenkins is configured globally for all repos in the Quattor org (via a web hook) so I don't think we can turn it off until we have an alternative configured for all repos. :-(

@ned21 ned21 added this to the 10.8 milestone Oct 13, 2020
@ned21 ned21 merged commit ce9462c into master Oct 13, 2020
@ned21 ned21 deleted the dependabot/maven/org.apache.ant-ant-1.10.8 branch October 13, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned21 ned21 ned21 approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Milestone

10.8

Development

Successfully merging this pull request may close these issues.

3 participants

@hpcugentbot @ned21 @jrha