panlint: Don't require component source files to include component config#236
Merged
jrha merged 1 commit intoquattor:masterfrom Dec 17, 2019
Merged
Conversation
Member
Author
|
Will add some tests shortly, although the lines of code are already covered, nothing tests that the regex is working correctly. |
fa0a905 to
6025ee5
Compare
Member
Author
|
Tests added. |
…nfig It would be rather silly and circular.
6025ee5 to
c5fd607
Compare
wpoely86
approved these changes
Dec 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should cut out much of the rubbish flagged against test files etc. and obviate some of the need for #225.