panlint: Add check for global variable names#219
Merged
ned21 merged 1 commit intoquattor:masterfrom Nov 13, 2019
Merged
Conversation
53148b3 to
803f0c6
Compare
Contributor
|
I am OK with adding these checks to panlint. I haven't checked the regexes though. |
Member
Author
|
This is the first of (hopefully) many PRs that I am pulling out of our rather messy development branch that I mentioned at the workshop, the code is all in use at RAL in one form or another. |
wpoely86
reviewed
Nov 30, 2018
Check that they have uppercase names longer than five characters Add unit tests for checks.
803f0c6 to
3180360
Compare
Contributor
|
@wpoely86 you have a stale review, are you happy with this now? If so please go ahead and approve & merge. |
Member
|
@ned21 I don't have merge rights. |
Contributor
|
@wpoely86 OK, can you given an "approved" and I'll do the merge? |
wpoely86
approved these changes
Nov 13, 2019
ned21
approved these changes
Nov 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check that they have uppercase names longer than five characters
Add unit tests for checks.