Conversation
|
does the rpm resolve all dependencies? in particular the colorama and prettytable ones? |
|
Nope. |
|
No, I haven't found how you can do that. Also, do we want to pull that in with the general panc rpm? Might be worth splitting off panlint into a independent python package? |
|
well, the very least requirements is that the panlint works. i'm not sure how critical the colorama and prettytable are for the functionality, but if not critical, wrap the imports in try/except and deal with the missing modules in the code. |
|
As @jrha mentioned that he's working on
|
|
I've updated this to also include the dependencies of panlint in the pan rpm. It's currently hard set to python2. Maybe we should split it off in a independent rpm with a python2 and python3 flavour? |
|
With Python2 reaching EOL on January 1st 2020, we should probably only be targeting Python3. |
|
panlint calls |
|
At this moment it works both under python2 and python3 but I'm all in favour of focusing on python3. |
|
@wpoely86 - cool, so what's blocking here? Remove the merge commit from this branch, rebase on master, make it work with py3 and we can merge? |
|
@hpcugentbot please test this please |
|
I've verified that the Maven tests all pass correctly locally, the RPM is built with the correct dependencies and installs correctly. |
fixes #133