Skip to content

Add panlint to rpm#214

Merged
jrha merged 3 commits intoquattor:masterfrom
wpoely86:panlint
Feb 16, 2022
Merged

Add panlint to rpm#214
jrha merged 3 commits intoquattor:masterfrom
wpoely86:panlint

Conversation

@wpoely86
Copy link
Member

fixes #133

@stdweird
Copy link
Member

does the rpm resolve all dependencies? in particular the colorama and prettytable ones?

@jrha
Copy link
Member

jrha commented Oct 30, 2018

Nope.

@wpoely86
Copy link
Member Author

No, I haven't found how you can do that.

Also, do we want to pull that in with the general panc rpm? Might be worth splitting off panlint into a independent python package?

@stdweird
Copy link
Member

well, the very least requirements is that the panlint works. i'm not sure how critical the colorama and prettytable are for the functionality, but if not critical, wrap the imports in try/except and deal with the missing modules in the code.
to add dependencies, have a look at https://github.com/quattor/CCM/blob/master/pom.xml#L278
if the rpms are in epel or main repo, it's ok
if not, we need to add them to the externals repo

@wpoely86
Copy link
Member Author

As @jrha mentioned that he's working on panlint, I will hold off any refactoring until I see a PR.

prettytable can easily be made optional, colorama is only used for colors which can also be made optional.

@wpoely86
Copy link
Member Author

I've updated this to also include the dependencies of panlint in the pan rpm. It's currently hard set to python2. Maybe we should split it off in a independent rpm with a python2 and python3 flavour?

@jrha
Copy link
Member

jrha commented Dec 5, 2019

With Python2 reaching EOL on January 1st 2020, we should probably only be targeting Python3.

@jrha jrha added the panlint label Jun 23, 2021
@ned21
Copy link
Contributor

ned21 commented Jun 28, 2021

panlint calls #!/usr/bin/env python -- do we believe it currently works on py2 and py3? We could continue to make it work on py2 but only ship py3 support in the rpm?

@wpoely86
Copy link
Member Author

At this moment it works both under python2 and python3 but I'm all in favour of focusing on python3.

@ned21
Copy link
Contributor

ned21 commented Jun 28, 2021

@wpoely86 - cool, so what's blocking here? Remove the merge commit from this branch, rebase on master, make it work with py3 and we can merge?

@jrha jrha added this to the 10.8 milestone Dec 24, 2021
@jrha
Copy link
Member

jrha commented Dec 24, 2021

@hpcugentbot please test this please

@jrha
Copy link
Member

jrha commented Feb 16, 2022

I've verified that the Maven tests all pass correctly locally, the RPM is built with the correct dependencies and installs correctly.
Seems like Jenkins is having issues again.

@jrha jrha merged commit 6ed1a15 into quattor:master Feb 16, 2022
@wpoely86 wpoely86 deleted the panlint branch February 16, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

package panlint with panc in the rpm

4 participants