Merged
Conversation
| <mainClass>org.quattor.pan.PanTest</mainClass> | ||
| </manifest> | ||
| </archive> | ||
| <descriptors> |
Member
There was a problem hiding this comment.
if this assembly file is only relevant for this fat jar, bets rename it to assembly-fat.xml or so
| * | ||
| * When building the panc-project a panc-MAJOR.MINOR-SNAPSHOT-fat-jar-with-tests.jar file is created. | ||
| * This jar can be used to execute pan test files and should be used as follows: | ||
| * `java -Dpanc.testdir="path" -Dpanc.tmpdir="path" -jar path/to/panc-MAJOR.MINOR-SNAPSHOT-fat-jar-with-tests.jar`. |
Member
There was a problem hiding this comment.
what are the exitcodes on succes, failure and error (like syntax exception)?
can you try to run some tests and check the $? value?
Contributor
Author
There was a problem hiding this comment.
@stdweird If the tests succeed, $? will be 0, otherwise it should be 1. When there's something wrong with the pan code itself or with the expected outcome, the correct error message will be displayed as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117