Merged
Conversation
| The choice-type | ||
| ~~~~~~~~~~~~~~~ | ||
| The choice type is an advanced type that can be used to create user-defined types. | ||
| It takes two or more strings as input arguments. These arguments represent the |
Member
There was a problem hiding this comment.
it's true that choice with one argument makes not much sense, but it should be possible (i assume it is). re rephrase this to one or more
Member
|
This title of this PR should be imperative, i.e. "Implement choice type", copying some of the description from the linked issue would also be helpful to people reading change logs later on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #114