Fix font package detection for fonts with spaces in names#13731
Merged
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Fonts with spaces (e.g., "Noto Emoji", "DejaVu Sans") were failing auto-installation because fontSearchTerm() generated search patterns that didn't match font files. Font files use concatenated names without spaces (NotoEmoji-Regular.ttf, DejaVuSans-Bold.ttf). Replace spaces with \s* regex pattern to match files with or without spaces. Closes #13726
6204d66 to
0f699f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rendering PDF with fonts that have spaces in names (e.g., "Noto Emoji", "DejaVu Sans"), automatic package installation fails:
The
fontSearchTerm()function preserves spaces, but font files concatenate names:NotoEmoji-Regular.ttf,DejaVuSans-Bold.ttf.Fix
Replace spaces with
\s*regex pattern for tlmgr search. Pattern now matches both with and without spaces.Verified with manual testing and unit tests.
Discovered while investigating #13726.
Opened upstream issue for R Markdown: rstudio/tinytex#478
Fixes #13732