Conversation
nkrackow
commented
Jun 15, 2022
nkrackow
commented
Jun 15, 2022
nkrackow
commented
Jun 15, 2022
nkrackow
commented
Jun 15, 2022
Contributor
Author
|
I still need to test the latest changes, especially hold on HW. |
jordens
requested changes
Jun 22, 2022
jordens
approved these changes
Jul 6, 2022
jordens
left a comment
Member
There was a problem hiding this comment.
Do the test benches still work?
Otherwise LGTM
jordens
approved these changes
Jul 6, 2022
jordens
left a comment
Member
There was a problem hiding this comment.
Do the test benches still work?
Otherwise LGTM
Contributor
Author
|
Yes, they were passing but I cleaned them up a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a servo on the RF outputs usind the ADCs and a iterative first order IIR.