Skip to content

consolidate root config for formatter-maven-plugin and impsort-maven-plugin#48372

Closed
Pankraz76 wants to merge 1 commit into
quarkusio:mainfrom
Pankraz76:centralize-plugin
Closed

consolidate root config for formatter-maven-plugin and impsort-maven-plugin#48372
Pankraz76 wants to merge 1 commit into
quarkusio:mainfrom
Pankraz76:centralize-plugin

Conversation

@Pankraz76

Copy link
Copy Markdown

it seems suitable to have only one root config now duplicated all over.

works on my machine:

image

@quarkus-bot quarkus-bot Bot added area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jun 13, 2025
@quarkus-bot

quarkus-bot Bot commented Jun 13, 2025

Copy link
Copy Markdown

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@Pankraz76

Copy link
Copy Markdown
Author

one config seems to be enough instead of duplicating many times.

@Pankraz76 Pankraz76 marked this pull request as ready for review June 13, 2025 13:38
@Pankraz76

Copy link
Copy Markdown
Author

is having one config possible? @gastaldi

@gsmet gsmet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense now that we have a common parent.

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 13, 2025
@quarkus-bot

This comment has been minimized.

@Pankraz76

Copy link
Copy Markdown
Author

thx.

@Pankraz76 Pankraz76 changed the title use root config of formatter-maven-plugin use root config for formatter-maven-plugin Jun 13, 2025
@Pankraz76

Copy link
Copy Markdown
Author

Caused by: org.apache.maven.plugin.PluginResolutionException: Plugin net.revelc.code.formatter:formatter-maven-plugin:2.26.0 or one of its dependencies could not be resolved:
Could not find artifact io.quarkus:quarkus-ide-config:jar:999-SNAPSHOT

@Pankraz76 Pankraz76 changed the title use root config for formatter-maven-plugin use root config for formatter-maven-plugin and impsort-maven-plugin Jun 14, 2025
@gsmet gsmet closed this Jun 14, 2025
@quarkus-bot quarkus-bot Bot added triage/invalid This doesn't seem right and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jun 14, 2025
@Pankraz76

Pankraz76 commented Jun 15, 2025

Copy link
Copy Markdown
Author

whats the reason for closing please?

I would like to improve Quarkus one commit at a time, as well.

https://www.goodreads.com/quotes/192325-it-is-not-enough-for-code-to-work

@Pankraz76

Copy link
Copy Markdown
Author

Cost of refactoring always outbalance, cost of carry.

@Pankraz76 Pankraz76 changed the title use root config for formatter-maven-plugin and impsort-maven-plugin consolidate root config for formatter-maven-plugin and impsort-maven-plugin Jun 18, 2025
@Pankraz76

Pankraz76 commented Jun 18, 2025

Copy link
Copy Markdown
Author

please consider reopen as seem to be valid increment.

this has do be done anyways when making next change, not to make it X times, but only once.

Like seen in:

@maxandersen

Copy link
Copy Markdown
Member

This PR was closed as part of a broader review of recent contributions.

We value efforts to improve consistency and tooling, but they need to create meaningful progress without adding unnecessary noise or maintenance overhead.

We appreciate the effort, but at this point, we’ve decided not to proceed with this specific PR.

For those considering similar contributions, we recommend starting with a focused issue, and if submitting a PR, ensure CI runs clean and avoid overloading maintainers with excessive volume of notifications. Clear communication and openness to feedback go a long way in making contributions successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform triage/invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants