consolidate root config for formatter-maven-plugin and impsort-maven-plugin#48372
consolidate root config for formatter-maven-plugin and impsort-maven-plugin#48372Pankraz76 wants to merge 1 commit into
formatter-maven-plugin and impsort-maven-plugin#48372Conversation
|
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
|
one config seems to be enough instead of duplicating many times. |
|
is having one config possible? @gastaldi |
gsmet
left a comment
There was a problem hiding this comment.
I think it makes sense now that we have a common parent.
This comment has been minimized.
This comment has been minimized.
|
thx. |
formatter-maven-pluginformatter-maven-plugin
|
Caused by: org.apache.maven.plugin.PluginResolutionException: Plugin net.revelc.code.formatter:formatter-maven-plugin:2.26.0 or one of its dependencies could not be resolved: |
formatter-maven-pluginformatter-maven-plugin and impsort-maven-plugin
|
whats the reason for closing please? I would like to improve Quarkus one commit at a time, as well. https://www.goodreads.com/quotes/192325-it-is-not-enough-for-code-to-work |
|
Cost of refactoring always outbalance, cost of carry. |
formatter-maven-plugin and impsort-maven-pluginformatter-maven-plugin and impsort-maven-plugin
|
please consider reopen as seem to be valid increment. this has do be done anyways when making next change, not to make it X times, but only once. Like seen in: |
|
This PR was closed as part of a broader review of recent contributions. We value efforts to improve consistency and tooling, but they need to create meaningful progress without adding unnecessary noise or maintenance overhead. We appreciate the effort, but at this point, we’ve decided not to proceed with this specific PR. For those considering similar contributions, we recommend starting with a focused issue, and if submitting a PR, ensure CI runs clean and avoid overloading maintainers with excessive volume of notifications. Clear communication and openness to feedback go a long way in making contributions successful. |
it seems suitable to have only one root config now duplicated all over.
works on my machine: