Skip to content

Support custom Flyway credentials/URL#29756

Merged
gastaldi merged 1 commit intoquarkusio:mainfrom
mfpc:credentials-datasource
Jan 27, 2023
Merged

Support custom Flyway credentials/URL#29756
gastaldi merged 1 commit intoquarkusio:mainfrom
mfpc:credentials-datasource

Conversation

@mfpc
Copy link
Copy Markdown
Contributor

@mfpc mfpc commented Dec 8, 2022 •
edited by gastaldi
Loading

@quarkus-bot
Copy link
Copy Markdown

quarkus-bot Bot commented Dec 8, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

@gastaldi
Copy link
Copy Markdown
Member

gastaldi commented Dec 13, 2022 •
edited
Loading

The problem with closing PRs for the same issue is that you miss important comments. I think this is what we're looking for: #29628 (comment)

Also with the snippet provided there, we no longer need the CredentialsDataSource, so you can remove that too

@gastaldi gastaldi force-pushed the credentials-datasource branch from 1f31923 to 3efba61 Compare December 13, 2022 15:05
@sberyozkin sberyozkin self-requested a review December 13, 2022 17:52
gsmet
gsmet reviewed Dec 13, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note that I want to have a look at this before we merge.

@gsmet gsmet self-requested a review December 13, 2022 17:56
gastaldi
gastaldi requested changes Dec 13, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some stuff missing. I'll meet with @mfpc later this week to finish it

@mfpc mfpc force-pushed the credentials-datasource branch from 3efba61 to f369b72 Compare January 16, 2023 18:34
gastaldi
gastaldi requested changes Jan 16, 2023
View reviewed changes
Comment thread ...eployment/src/test/java/io/quarkus/flyway/test/FlywayExtensionCredentialsDatasourceTest.java Outdated
Comment thread ...ns/flyway/runtime/src/main/java/io/quarkus/flyway/runtime/FlywayDataSourceRuntimeConfig.java Outdated
gastaldi
gastaldi reviewed Jan 17, 2023
View reviewed changes
Comment thread extensions/flyway/runtime/src/main/java/io/quarkus/flyway/runtime/FlywayCreator.java Outdated
@gastaldi gastaldi marked this pull request as draft January 17, 2023 20:13
@gastaldi gastaldi mentioned this pull request Jan 18, 2023
Merged
@mfpc mfpc force-pushed the credentials-datasource branch 3 times, most recently from e7a7b1a to fa33f15 Compare January 19, 2023 19:01
@quarkus-bot quarkus-bot Bot added area/arc Issue related to ARC (dependency injection) area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/maven area/persistence OBSOLETE, DO NOT USE area/reactive-messaging area/smallrye area/tracing labels Jan 19, 2023
@gastaldi gastaldi force-pushed the credentials-datasource branch from 1fc620b to 78ae70d Compare January 19, 2023 20:02
@gastaldi gastaldi force-pushed the credentials-datasource branch from 853a2e2 to 65720ea Compare January 23, 2023 18:05
@quarkus-bot

This comment has been minimized.

Sign in to view
@gastaldi gastaldi force-pushed the credentials-datasource branch 3 times, most recently from 6be8c24 to 815c1a7 Compare January 23, 2023 19:12
@quarkus-bot

This comment has been minimized.

Sign in to view
@gastaldi
Copy link
Copy Markdown
Member

gastaldi commented Jan 24, 2023

@gsmet kind reminder to have a look when possible ;)

@gsmet gsmet self-assigned this Jan 26, 2023
gsmet
gsmet requested changes Jan 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted a few minor issues, I will fix them.

Comment thread ...ons/flyway/deployment/src/test/java/io/quarkus/flyway/test/FlywayExtensionConfigFixture.java
Comment thread extensions/flyway/runtime/src/main/java/io/quarkus/flyway/runtime/FlywayCreator.java Outdated
Comment thread ...ns/flyway/runtime/src/main/java/io/quarkus/flyway/runtime/FlywayDataSourceRuntimeConfig.java Outdated
@mfpc @gastaldi @gsmet
Support custom Flyway credentials and URL
e7d1d24 
- Introduces `quarkus.flyway.username`, `quarkus.flyway.password` and `quarkus.flyway.jdbc-url` config options

Co-Authored-By: George Gastaldi <gegastaldi@gmail.com>
Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com>
@gsmet gsmet force-pushed the credentials-datasource branch from 815c1a7 to e7d1d24 Compare January 27, 2023 15:20
gsmet
gsmet approved these changes Jan 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied a few minor changes. Things should be good to go now. Thanks!

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 27, 2023
@quarkus-bot
Copy link
Copy Markdown

quarkus-bot Bot commented Jan 27, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gastaldi gastaldi merged commit b137f1b into quarkusio:main Jan 27, 2023
@quarkus-bot quarkus-bot Bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 27, 2023
@quarkus-bot quarkus-bot Bot added this to the 2.17 - main milestone Jan 27, 2023
@quarkus-bot quarkus-bot Bot added the kind/enhancement New feature or request label Jan 27, 2023
@chrisruffalo
Copy link
Copy Markdown
Contributor

chrisruffalo commented Feb 8, 2023

@gsmet @gastaldi is there any chance for this to be backported into 2.15 or 2.16?

@gastaldi
Copy link
Copy Markdown
Member

gastaldi commented Feb 8, 2023 •
edited
Loading

@chrisruffalo I marked it to be backported to 2.16.2.Final. 2.15 is not possible (because it depends on #30455)

UPDATE: Oh, it seems that 2.16.2.Final is out, I'll leave the backport decision to @gsmet

@chrisruffalo
Copy link
Copy Markdown
Contributor

chrisruffalo commented Feb 8, 2023

@gastaldi 2.16 or would be amazing, 2.17 would be good as well. I'm not sure our timelines align with 3.0.

@gastaldi
Copy link
Copy Markdown
Member

gastaldi commented Feb 8, 2023

There are no plans for a 2.7, the next release is 3.0. We're working hard on it

@chrisruffalo
Copy link
Copy Markdown
Contributor

chrisruffalo commented Feb 9, 2023

@gastaldi that makes sense, thanks.

@gsmet gsmet modified the milestones: 3.0.0.Alpha4, 2.16.3.Final Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gastaldi gastaldi gastaldi approved these changes

@sberyozkin sberyozkin sberyozkin approved these changes

@gsmet gsmet gsmet approved these changes

@geoand geoand geoand approved these changes

Assignees

@gsmet gsmet

Labels

area/flyway kind/enhancement New feature or request release/noteworthy-feature

Projects

None yet

Milestone

2.16.3.Final

Development

Successfully merging this pull request may close these issues.

configure dedicated db user for database migrations: DML-only user for datasource, but DDL user for migration

6 participants

@mfpc @gastaldi @chrisruffalo @sberyozkin @gsmet @geoand