[binexport] Refactor ISA guessing heuristic #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add warnings when having to rely on context guess and use thumb when the instruction is 2 bytes. Beware that IDA sometimes likes to merge two (or more?) thumb instructions together.
Collaborator
|
As we can now specify the arch+mode through command line, I am not sure we want to keep guessing the mode dynamically. We could just fail gently if the user supply ARM binaries without the associated arch+mode. The code is looking way better. Let's keep it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better logging messages and clean the code for the ISA guessing heuristics (only used when the architecture is not manually specified)