Conversation
Paragraphs following nested lists after blank lines were incorrectly being absorbed into the nested list item instead of being parsed as separate blocks. This fix ensures paragraphs are correctly separated from nested lists per CommonMark specification.
🦋 Changeset detectedLatest commit: 1e98d91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bc329e9 to
8782c1a
Compare
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on February 7
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Lists and other markdown structures were incorrectly parsed when input had CRLF line endings. This fix ensures CRLF line endings are properly handled as line boundaries without requiring input normalization.
Extract shared utilities to reduce code duplication in parseRefContent and parseFootnoteContent. New helpers (isBlockStartAt, isTitleDelimiter, parseQuotedTitle, parseParenTitle, scanFootnoteEnd) consolidate repeated patterns across reference and footnote parsing. - parseRefContent: 507→383 lines (-24%) - parseFootnoteContent: 185→123 lines (-34%) - Net reduction: 53 lines All tests passing, performance within 5% of baseline.
- parseQuotedTitle: detect CRLF blank lines to reject invalid titles - parseParenTitle: detect CRLF blank lines to reject invalid titles - scanFootnoteEnd: detect CRLF blank lines to stop absorbing content - Add CHAR_PAREN_OPEN/CLOSE constants - Remove unused scanToBlankLine function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Ensures consistent parsing with Windows-style CRLF inputs and correct block boundaries around lists.
normalizeCRLFand adjustfindLineEnd/skipToNextLine; treat CRLF as a single newline and preserve lone CRWritten by Cursor Bugbot for commit 1e98d91. This will update automatically on new commits. Configure here.