Skip to content

Issues compiling on macOS 10.12 with libxml2 include dirs#429

Merged
annulen merged 2 commits intoqtwebkit:qtwebkit-stablefrom
sinspiral:macos-libxml2
Feb 7, 2017
Merged

Issues compiling on macOS 10.12 with libxml2 include dirs#429
annulen merged 2 commits intoqtwebkit:qtwebkit-stablefrom
sinspiral:macos-libxml2

Conversation

@sinspiral
Copy link
Copy Markdown

When compiling for macOS 10.12 (Sierra) it is failing to find <libxml/parser.h>. This was working fine when using tp4.

It seems that MACOS_FORCE_SYSTEM_XML_LIBRARIES was introduced in the cmake process to avoid conflicts when using homebrew or MacPorts.

The problem I found was that those include folders were directing referring to /usr/include/libxml2. Also if you are linking against a specific SDK (10.10 in my case) it won't be able to find them,

@annulen
Copy link
Copy Markdown
Member

annulen commented Feb 7, 2017

Thanks for spotting this!

It seems that MACOS_FORCE_SYSTEM_XML_LIBRARIES was introduced in the cmake process to avoid conflicts when using homebrew or MacPorts.

Indeed, this is needed to avoid linking official binaries (which are built in Qt CI system) to libxml2 from MacPorts

@annulen annulen merged commit ea65579 into qtwebkit:qtwebkit-stable Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants