Update Bright Nights modpack to new maintainer Zlor's repo#181
Merged
AriaMoradi merged 1 commit intoqrrk:masterfrom Nov 16, 2024
Merged
Update Bright Nights modpack to new maintainer Zlor's repo#181AriaMoradi merged 1 commit intoqrrk:masterfrom
AriaMoradi merged 1 commit intoqrrk:masterfrom
Conversation
Collaborator
|
Thanks for the PR, I have been meaning to do this myself at some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kenan2000 is no longer maintaining his modpacks for DDA and BN, but in the case of BN, Zlorthishen has taken up maintaining the pack in a new fork. I haven't really been able to find an "official" announcement that I could link here as of yet, but the
#zlor-modschannel on the Bright Nights Discord server recognizes Zlor as the new maintainer.This PR redirects Catapult to Zlor's new fork when retrieving the new fork when Bright Nights is selected.
For testing, I imported the project into Godot and was able to run the project and get the new version of the modpack when running from within Godot.
I'm honestly not sure why the
Archive extraction command exited with an error (exit code: 50)line appears, though it also does that when launching in Godot without my changes present, and the files all seem to extract properly anyway, and I was able to successfully start a game with a number of the mods from the pack turned on.I tried to export the project based on the instructions in CONTRIBUTING.md, but was running into issues with all of the text being missing. If I can figure out the exporting, I can get a screenshot from there and see if the archive extraction error is still there. Beyond that, let me know if there are any other updates to be made!