Add proxy support and cache options; Refine chinese locales.#157
Merged
AriaMoradi merged 2 commits intoqrrk:masterfrom Jul 16, 2024
Merged
Add proxy support and cache options; Refine chinese locales.#157AriaMoradi merged 2 commits intoqrrk:masterfrom
AriaMoradi merged 2 commits intoqrrk:masterfrom
Conversation
AriaMoradi
approved these changes
Jun 30, 2024
Collaborator
AriaMoradi
left a comment
There was a problem hiding this comment.
Looks good to me, We'll wait for qrrk's approval for some time and then merge either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For certain reasons, it's always been hard for general players in Chinese mainland to establish stable internet connections with GitHub, which is the main cause for me to make this PR. Besides, I also think it would be useful if Catapult could install from a local build.
To the point, this PR:
Adds proxy support
All HTTP requests now follow the proxy configured in
Settingstab. Options includeDisabled(default),EnabledandFor Downloading Only.Adds cache options
Ignore download cachealters this behavior. This avoids unnecessary downloading. Also I can manually put zip files there now, when downloading isn't really an option.Keep download cacheto not delete the zip file after extracting.cache, to avoid clutter.Though it still lacks a part named "detect cache when fetching available builds" to make "offline mode" a real thing, but persisting cache can be the first step, I think. BTW the cache also does help in checking potential problems caused by corrupted files.
Refines Chinese locales
Might not be the best, but certainly better I would say. I don't know how my English really sounds like but I'm confident in my Chinese. Fixes some mistranslations caused by polysemy; changes some terms and expressions - majorly the
Gametab.All changes have been tested locally, but it's always better to test more.