fix: more robust error output in face of unknown errors#121
Merged
Conversation
Contributor
|
Diff Coverage: The code coverage on the diff in this pull request is 92.6%. Total Coverage: This PR will decrease coverage by 0.57%. File Coverage Changes
🛟 Help
|
brynary
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A customer recently reported an error running this action and the ouput of the action was simply:
This would happen, I believe, if an error occurs with the actual attempt to execute the qlty binary, as opposed to an error output by
qlty.We were not catching the
errorobject in the try/catch blocks here, so effectively we're losing information when an error occurs.This enhances our error reporting so that if an error occurs, and there's no output from the tool, we instead output information from the try/catch's error object.
I also fixed a couple cosmetic issues (typos in descriptions or variable names)