vcpkg bump + report#66239
Conversation
VCPKG_BUILD_TYPE=release triplets (e.g. x64-windows-release) don't install debug libs, so find_library(ZLIB_DEBUG ... REQUIRED) fails fatally even though add_libs_dbg is unused in release-only builds. Gate the debug lookup on the build type.
Two related fixes for the case where vcpkg fails before any port leaves a parseable buildtree (e.g. a CMake Error in portfile.cmake from find_library REQUIRED, or vcpkg_extract_source_archive download failure). Previously the parser saw nothing and the report claimed 'all ports built ✅' despite a non-zero exit code.
1. parse_failures.py: new --manifest-install-log option that scans vcpkg-manifest-install.log for 'error: building <port>:<triplet> failed with: BUILD_FAILED' lines and 'CMake Error at .../ports/<port>/portfile.cmake' blocks, synthesizing failure records (with excerpts) for ports that never produced a buildtree.
2. format_report.py + action.yml: new build-status input. When the upstream build/configure step failed but no per-port failures were parsed, render a 'vcpkg failed before producing per-port logs' banner with links to the artifacts/run instead of the misleading 'all ports built' line.
Both windows-qt6.yml and build-macos-qt6.yml now pass build-status=${{ job.status }} and manifest-install-log=${{ github.workspace }}/build/vcpkg-manifest-install.log.
…51235 Drop the REQUIRED + VCPKG_BUILD_TYPE gating in favour of the broader name set used in the upstream vcpkg fix (which also handles the static linkage 'zs.lib' / 'zsd.lib' produced by the new zlib 1.3.2 port). release: z zs zlib debug: zd zsd zlibd Ref: microsoft/vcpkg#51235
GitHub evaluates ${{ ... }} expressions inside input descriptions too, so the previous wording caused the composite action to fail to load with 'Unrecognized named-value: job'. Rephrase the description to avoid the expression syntax.
Fixes the action.yml validation error seen in workflow run 69945800777.
libpq's portfile uses vcpkg_copy_tools(TOOL_NAMES pg_config ...) without a DESTINATION, so the binary lands at tools/libpq/pg_config — not tools/libpq/bin/pg_config. The else() branch of py-psycopg-c had the wrong path, causing the build to fall back to PATH lookup of pg_config (not present) and fail with 'No such file or directory'. Match the Windows branch which already uses tools/libpq with no /bin. Failure seen on arm64-osx-dynamic-release / x64-osx-dynamic-release in workflow run 69945800777.
Both fixes have landed in their respective upstream registries (microsoft/vcpkg for libxml2, open-vcpkg/python-registry for py-psycopg-c). The overlay copies are no longer needed.
Pulls in py-psycopg-c 3.3.4#3 (pg_config path fix) and other recent updates from open-vcpkg/python-registry.
Adds an optional commit-sha input. When set, the rendered report footer shows a linked short SHA (e.g. 📌 Commit `abc1234`) so reviewers know which revision the sticky comment reflects. Wired up the windows-qt6 and build-macos-qt6 workflows to pass github.event.pull_request.head.sha (with fallback to github.sha).
Integrates open-vcpkg/python-registry#240 ([py-psycopg-c] Make it usable without pg_config) which fixes the pg_config path issue on non-Windows post-meson refactor of microsoft/vcpkg's libpq port.
🪟
|
re-creating the PR since the old one is now 404... (#66006 really strange)