Fix/wms provider url decoding#59144
Closed
cioddi wants to merge 32 commits into
Closed
Conversation
We should not decode an entire URL if it includes parameters, as special characters in the query string (like `&`, `=`) must remain URL-encoded to avoid breaking the structure of the request. Within the URL-parameter values must never be URL-decoded as it leads to a loss of information, this is also the case if only non reserved characters are decoded. There is no way to know whether those characters have been encoded in the first place.
…roperly decoded when retrieved, preventing any potential loss of information.
URl-encoded in URL-parameter values characters will be URL-decoded on retrieval.
Contributor
🪟 Windows buildsDownload Windows builds of this PR for testing. |
…ded in tests/src/providers/testqgswmsprovider.cpp
Collaborator
|
Tagging as frozen -- this should not be merged prior to 3.40, as there's too great a risk of regressions at this late stage in the release cycle |
elpaso
reviewed
Oct 21, 2024
Contributor
Author
|
I agree, this needs to be done with care. So definitely not 3.40. @elpaso I will see whether it can be done when URI is serialized. |
… QgsDataSourceUri param setter and getter functions to URI serialization QgsDataSourceUri::encodedUri()
…sDataSourceUri strings in QgsDataSourceUri::setEncodedUri
…n TestQgsIdentify::identifyVectorTile(), as QgsDataSourceUri now reliably returns the values that were provided.
Contributor
Author
|
I set this "Ready for review" just to enable the GH actions tests but it seems like one of the maintainers has to approve them. |
2 tasks
Contributor
|
@cioddi I'd like to help get this pr merged, let me know if anything needs doing, although likely won't be able to get to it until the new year |
commit e55c6bbe311d67b02824be7a0e358aa1f247009b
Merge: 923b03dc35 8acedaed61
Author: Julien Cabieces <julien.cabieces@oslandia.com>
Date: Thu Dec 19 09:37:47 2024 +0100
Merge pull request #59915 from YoannQDQ/fix-action-tooltip
Fix text inside parentheses disappears from action tooltip
commit 923b03dc35ece5254f2362d7ffd2d3c6d063c8c0
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 19 07:41:12 2024 +1000
Make test more stable across different platforms
And just skip for older GEOS patch version with known issue, instead of
adding complexity to the test
commit 53e174f05e3ecd26b0cd7d25f77b4ca45dd9e2e5
Merge: c95d63c175 c1809728ff
Author: Alexander Bruy <alexander.bruy@gmail.com>
Date: Wed Dec 18 18:56:38 2024 +0000
Merge pull request #59949 from nyalldawson/grass7im
Fix grass imagery tests on newer GRASS versions
commit 8acedaed61da9a64f4602015e6c063e2cd673211
Author: Yoann Quenach de Quivillic <yoann.quenach@gmail.com>
Date: Wed Dec 18 18:26:59 2024 +0100
Apply suggestion from review
commit c95d63c175807a77852b4d06a479a0bb83aa0b93
Author: qgis-bot <bot@qgis.org>
Date: Wed Dec 18 09:15:18 2024 +0000
auto sipify 🍺
commit 851e36013cc961cf239807d2b258bc58feb815bc
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 18 16:05:06 2024 +1000
Show labeling in raster layer properties dialog
commit e5379a7b5cb17e147c9fdb3a14f71089ef28195b
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 18 15:00:35 2024 +1000
Remove a lot of hardcoded tab indexes
commit 6408267d95839fff99cdded171086868e609d2af
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 18 14:27:02 2024 +1000
Address review
commit 986a859baf0710c82c5d2b3ac606d75072d0d4ee
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Dec 10 06:41:56 2024 +1000
Fix clang-tidy warning
commit de90261deabd63f62dc4eae441ebe6d7da2b8f0c
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Dec 10 06:40:09 2024 +1000
Add test mask
commit a3f4b849f1078c852862141e7efc1e8609883516
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Mon Dec 9 15:08:24 2024 +1000
Support raster labels for resampled values across neighboring pixels
commit c2d933579d20c331e05899b1241986bb17165079
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Mon Dec 9 14:34:08 2024 +1000
Move resampling method enum to Qgis, promote to enum class
commit 2bf6d34a600991818521f98d02d781cbff9c691d
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Mon Dec 9 08:20:12 2024 +1000
Style
commit 87ec3b2211c4741680a0d6f896b0554ee34c96f1
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Fri Dec 6 13:53:57 2024 +1000
Fix clang tidy warning
commit 17066b14cbee493ba6da598ca7c30e1753981072
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Fri Dec 6 13:52:28 2024 +1000
Add test masks
commit 88908b73803e987174b65ee97db031d372f8e408
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Fri Dec 6 11:40:50 2024 +1000
Stablise transform for test
commit 30867e3af0ce2afecae413d5ef476ebdfa2a8cc4
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Fri Dec 6 11:33:02 2024 +1000
Only write labelsEnabled attribute when labels are enabled
Keeps XML minimized when not required
commit 8d0aa9f39f864c888c920a7e27f4017d6a14642c
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Fri Dec 6 06:19:02 2024 +1000
Remove unused
commit d9d501a3d89a4e1d4ffc9447b7bedef9520e7002
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 5 18:07:48 2024 +1000
Fix see also link
commit 6d95a8409731018008a1ce3f088cb2779e22ebc7
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 5 18:07:11 2024 +1000
Fix build
commit ebfa42580478628abc5aa7b1a419a520d0adb89f
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 5 15:54:37 2024 +1000
Add missing moc
commit 667ba086e3e9fc869112d46c2ec6cb8b79dc7ab6
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 5 15:54:10 2024 +1000
Fix mode for script
commit c33b8b276fd1cef8feae5c672263d93447816efa
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 5 15:52:41 2024 +1000
Fix documentation
commit b392630dc4ccbbcf1f9b82b5b4815e8e030ec027
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 5 15:50:36 2024 +1000
Fix default settings are not shown in widget
commit 4d97c7192f6aada41bec792e2ecfee87a22d8869
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 5 14:15:21 2024 +1000
Add GUI for configuring raster labeling
commit 14f625f59fab03b6ed9617f5eaa606b9c94db125
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 5 14:14:51 2024 +1000
[API] Add framework for raster labeling
Allows raster pixels to be labeled with the value taken from a raster
band.
Labels are registered with the labeling engine, so participate in
label conflict resolution and overlap avoidance
Options include
- Selection of band to take values from
- Using QgsNumericFormat to customise the number format for the labels
- Uses text renderer, so supports buffers, shadows, etc
- Label priority
- Scale dependant visibility
- Optional pixel size dependent visibilty, ie show only when pixels are
> 4mm in size
- Z index control, overlap avoidance mode
Fixes #14408
commit fce6cee155e2a61a462b7ff322f3dc6a0408a1bd
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Dec 3 14:12:05 2024 +1000
Improve docs
commit 3fac23e63575c35b48cd77e6594f704647fca3b0
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Dec 3 11:55:20 2024 +1000
Cleanup construction of QgsLabelingGui to make it more accessible for subclassing
commit f708cbd948571762b27713146ff4daaba1ab1eb6
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Dec 3 11:52:33 2024 +1000
Remove duplicate map canvas member in subclass, use base class member instead
commit 1c3d2ae06a79bbe0cef310a1881efb34afd59151
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Dec 3 11:49:18 2024 +1000
Expose method as protected
commit b7f78e8c73d5c385d7a912db30da2f7b6b2d1bbc
Author: qgis-bot <bot@qgis.org>
Date: Wed Dec 18 08:10:21 2024 +0000
auto sipify 🍺
commit 8c4ffe565a7f65dd6ec70285c65ab6c2a9363392
Author: Jean Felder <jean.felder@oslandia.com>
Date: Tue Dec 17 19:07:39 2024 +0100
qgs3dmapcanvaswidget: Display a message to report export success state
With this change, the messagebar is used to show a message if the
export operation failed or succeeded.
commit fe4ca94c7efe45a5ddb14c70e242165e89b412d2
Author: Jean Felder <jean.felder@oslandia.com>
Date: Tue Dec 17 19:08:36 2024 +0100
qgs3dmapcanvaswidget: Give a proper name to QgsMap3DExportWidget
commit 30a9e93d6bc6c1151529fa787e3177bdfc76fdeb
Author: Jean Felder <jean.felder@oslandia.com>
Date: Tue Dec 17 18:11:34 2024 +0100
qgsmap3dexportwidget: Return export scene operation success state
commit 1c48cfd07f0d583c9d7a94e5ee7b446239090fa9
Author: Jean Felder <jean.felder@oslandia.com>
Date: Mon Dec 16 17:50:43 2024 +0100
qgs3dmapscene: : Return export operation success state
commit 04738f53310bcd1f55990cc7a446062e34984299
Author: Jean Felder <jean.felder@oslandia.com>
Date: Mon Dec 16 17:48:45 2024 +0100
qgs3dsceneexporter: Return save operation success state
commit 1600555ce327953a6bc9cfb6f0154060edfafafb
Author: Jean Felder <jean.felder@oslandia.com>
Date: Mon Dec 16 17:47:06 2024 +0100
qgs3dsceneexporter: Do not try to save if mObjects is empty
commit 95a36c91e1714a9dbed23ed6bb364b634d059b90
Merge: a1863a430f f3cd1851e7
Author: Alessandro Pasotti <elpaso@itopen.it>
Date: Wed Dec 18 08:52:34 2024 +0100
Merge pull request #59952 from nirvn/calendar_form_fix
[ui][themes] Fix calendar view when constraints are not met
commit c11bb42cf3d09041ed76c81b5f9eadf8d692407b
Author: Yoann Quenach de Quivillic <yoann.quenach@gmail.com>
Date: Wed Dec 18 08:40:08 2024 +0100
Fix #59914
commit a1863a430fd3cd11bbad4e03b4e9552930ab4c94
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 18 14:18:35 2024 +1000
Skip test on Geos >= 3.11
Broken due to https://github.com/libgeos/geos/issues/1037
commit f3cd1851e7ccd22c371d5f1e9e62a86c9a029944
Author: Mathieu Pellerin <nirvn.asia@gmail.com>
Date: Wed Dec 18 12:05:43 2024 +0700
[ui][themes] Fix calendar view when constraints are not met
commit c1809728ffe32d380c501d6f9be9bb01ed45a309
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 18 15:04:49 2024 +1000
Fix regex
commit 6318e14b624a87d4d726f0f8a936cab1aa05026b
Author: qgis-bot <bot@qgis.org>
Date: Wed Dec 18 03:23:57 2024 +0000
auto sipify 🍺
commit 72e1b8250930d6642dfb613b1c46b43156b8b5ea
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 18 11:21:12 2024 +1000
Remove dead code
commit 75c8e3e2c48a19b40a88eaf3494feaa23f5750dd
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 18 11:20:23 2024 +1000
Fix memory leaks in classification methods, use unique_ptrs
commit 787f8072d1393754c989b783391e49247b060326
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 18 13:19:55 2024 +1000
Enable test which passes now
commit 176dadfaffd6c283d3907ce8ea1c180bdb672086
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 18 13:18:14 2024 +1000
Run test on qt 6
commit d3df8c13cbf81db2c833873f6f06a0a694f54f49
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 18 13:14:19 2024 +1000
Only run i.smap , i.maxlik tests on older GRASS
Newer ones have the raster paths hardcoded into
the signature file, and we can't handle that currently
in the test suite
commit 6aa594dcb6f86c710a9d9111fabdb845e7628361
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 18 13:13:35 2024 +1000
Allow skipping tests by grass version
commit 67a67c30e908bd36c0dfe776c0e98704f502f2aa
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 18 13:08:02 2024 +1000
Resync grass plugin algorithm test base file
commit 49f9cfb358e20a81307ddf8669c1b6f8a7c2fb10
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 18 13:03:11 2024 +1000
Adapt some grass tests to account for formats used in newer GRASS versions
commit b4f6d2e907152369a7e60f6f76cc9b1a12b5f7aa
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Mon Dec 16 13:50:33 2024 +1000
Run test on qt6
commit 06291f790c6a6a366d6ac97ab8a73a0c49d85b7a
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Mon Dec 16 13:49:05 2024 +1000
Disable broken test for automatic transaction groups on GDAL >= 3.5
This functionality is broken on newer GDAL versions, due
to incorrect assumptions at time of development.
See https://github.com/qgis/QGIS/pull/59797#issuecomment-2544133498
Parties interested in seeing this test resurrected are welcome
to submit fixes.
commit 464b63d47c1b11416e64a9bf87af59de4cd3ee03
Author: Alexander Bruy <alexander.bruy@gmail.com>
Date: Tue Dec 17 11:17:21 2024 +0000
fix build
commit cb4822c073ff79e8a5385553ce069eadf46c7d8a
Author: Alexander Bruy <alexander.bruy@gmail.com>
Date: Tue Dec 17 09:35:59 2024 +0000
fix condition
commit 3602d5891b0c2c1781edbc6c44034d36e84115a1
Author: Alexander Bruy <alexander.bruy@gmail.com>
Date: Tue Dec 17 09:27:18 2024 +0000
address review comments
commit d587f8c9a62657b7c5d28ff829cfdc05a88cf445
Author: Alexander Bruy <alexander.bruy@gmail.com>
Date: Mon Dec 16 13:33:52 2024 +0000
simplify conditions
commit ac894db086be7a1f7eba9b1dc1825c6ee4a284df
Author: Alexander Bruy <alexander.bruy@gmail.com>
Date: Mon Dec 16 12:52:18 2024 +0000
add option to ignore empty metadata fields
commit 446d345818b22ead37d2264f963c6143e9c7e24b
Author: Alexander Bruy <alexander.bruy@gmail.com>
Date: Fri Dec 13 15:05:53 2024 +0000
add native set metadata fields algorithm
commit 67f8475646923814faa9cc96e3a94ba671f303c7
Author: Alexander Bruy <alexander.bruy@gmail.com>
Date: Fri Dec 13 13:30:30 2024 +0000
add native update layer metadata algorithm
commit 98d55e30180021c0223681aa6e688dc6c5d48acb
Author: Alexander Bruy <alexander.bruy@gmail.com>
Date: Fri Dec 13 12:45:19 2024 +0000
add native add history metadata algorithm
commit 53e777fd975befd181941f72a955e444727f6e73
Author: Harrissou Sant-anna <delazj@gmail.com>
Date: Mon Dec 16 22:26:24 2024 +0100
Typo fix
commit a15b9a159b8d3a275f81f999375c6ed5789e9503
Author: Harrissou Sant-anna <delazj@gmail.com>
Date: Mon Dec 16 01:15:36 2024 +0100
Add help button to labeling rules dialogs
commit 103990eabb58328cc106cee9ed6e4b6298f58800
Author: Matthias Kuhn <matthias@opengis.ch>
Date: Tue Dec 17 10:15:27 2024 +0100
Fix TOC
commit 7c381634739fa73763c67bd1b7afa0e88857ae2c
Author: Matthias Kuhn <matthias@opengis.ch>
Date: Tue Dec 17 10:02:14 2024 +0100
Document building with qt6 for macos
commit 3139f3daafa5b8d6c798ac90a8afa2d955664cc1
Author: Gijs Nijholt <gijs.nijholt@gmail.com>
Date: Tue Dec 17 11:27:27 2024 +0100
Adds a 'system-ui' font-family to the oauth2 verification finished page. See https://css-tricks.com/snippets/css/system-font-stack/ for details on this.
commit d1232ebe5a783109b95a810168b8c5b81890aa91
Merge: 98e89dcbb3 d7e819de38
Author: Alexander Bruy <alexander.bruy@gmail.com>
Date: Tue Dec 17 17:33:10 2024 +0000
Merge pull request #59928 from agiudiceandrea/patch-42
[Modeler] Fix algorithms help URL (Followup #59922)
commit 98e89dcbb3f5514f2317d2375407fa470822e319
Merge: 3e0b74418d 2e83b6b424
Author: Alexander Bruy <alexander.bruy@gmail.com>
Date: Tue Dec 17 10:46:19 2024 +0000
Merge pull request #59931 from nyalldawson/fix_test_close
Avoid unclosed file warning in test
commit 3e0b74418db340ea4e790f50db972d4c0b4c311f
Merge: e6134fd0a7 ebfa41cefa
Author: Julien Cabieces <julien.cabieces@oslandia.com>
Date: Tue Dec 17 11:17:30 2024 +0100
Merge pull request #59926 from nyalldawson/thin_xml
Don't write unnecessary attribute to XML when saving point cloud layers
commit e6134fd0a718ea8752e8bafa7070b85f5065bf12
Merge: 5349b26a06 c9981ad102
Author: Julien Cabieces <julien.cabieces@oslandia.com>
Date: Tue Dec 17 11:15:22 2024 +0100
Merge pull request #59806 from GispoCoding/53696_keep_id_of_largest_feature
[digitizing] Split features: always give largest geometry to original feature
commit 5349b26a06133804f1b2b8e37700de99e7c9ead0
Author: qgis-bot <bot@qgis.org>
Date: Tue Dec 17 09:52:52 2024 +0000
auto sipify 🍺
commit 62c6b9143765c837dc75fc7d4284aeac0e6f16b3
Merge: 73c740c767 4eab5313e6
Author: Julien Cabieces <julien.cabieces@oslandia.com>
Date: Tue Dec 17 10:50:02 2024 +0100
Merge pull request #59834 from troopa81/sip_deprecated
[PyQGIS] Add message to /Deprecated/ annotations
commit 2e83b6b424410d1e2c9df6e0fef721b0e4f34c3c
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Dec 17 18:23:28 2024 +1000
Avoid unclosed file warning in test
Maybe will help with test fragility
commit 73c740c767e01370c0b940e1a5f206212b55aa16
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Dec 17 11:40:35 2024 +1000
Fix leak in point cloud exporter
commit 527d5113a1f073ad121cc63ce8faf3f888cdee77
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Dec 17 11:36:29 2024 +1000
Fix leak
commit ff93979421ef2f876f30a3a75110eeb6b70f7f5b
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Dec 17 11:32:10 2024 +1000
Fix leak
commit 91b953d8af8303fa29a7c4cfcf779727923faaf0
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Dec 17 11:30:18 2024 +1000
Fix coverity overflowed constant warning
commit 613b2cae71e037c7fdbd0cc3da4976289ec07889
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Dec 17 11:28:57 2024 +1000
Fix coverity 'nesting level does not match indentation' warnings
The QgsDebugMsgLevel macro is multiline, so we need to enclose it in braces
commit a0d4861bc784b6d993b57092bf5d0bed2d761ebb
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Dec 17 07:46:17 2024 +1000
Use unique_ptr
commit ab46cf3205652766762b499a4399245a4386b3d8
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Mon Dec 16 11:32:21 2024 +1000
Remove some useless calls
commit 14fed11840b79026e419addef706e2da9e260906
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Mon Dec 16 11:31:19 2024 +1000
Fix coverity nullptr dereference warning
commit 76ef9c80bea46eb3b860cd510000ed3adede687e
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Mon Dec 16 11:30:56 2024 +1000
Fix some use of deprecated implicit capture of this
commit e06d561f1387a5c1b0053a1c573eec76ea1714ed
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Mon Dec 16 11:29:53 2024 +1000
Fix coverity nullptr dereference warning
commit 44f4c2db9170752f35343b5b557af1d97d62aa3e
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Mon Dec 16 11:29:08 2024 +1000
Fix some uninitialized members
commit 4eab5313e6b60396c0012d6244e1148efb2c7946
Author: Julien Cabieces <julien.cabieces@oslandia.com>
Date: Tue Dec 17 09:07:41 2024 +0100
fix(Sip): update sip since rebase
commit 209043e21e97be1ca78378f97afce7d8190a320b
Author: Julien Cabieces <julien.cabieces@oslandia.com>
Date: Mon Dec 16 17:07:51 2024 +0100
build(QSci): fix build when python QSci is missing
commit 0fdb3508a5c159a7f23bb03456c7b7429a214306
Author: Julien Cabieces <julien.cabieces@oslandia.com>
Date: Mon Dec 16 16:48:28 2024 +0100
api(Deprecated): Remove strong requirement on \deprecated
Because some method (only QgsGeometry::set actually) can be deprecated
only in python, not in C++. But \deprecated triggers the need for Q_DECL_DEPRECATED
commit 51dc2ec2ac717585f67e7fc5e8bf863ad78dd742
Author: Julien Cabieces <julien.cabieces@oslandia.com>
Date: Mon Dec 16 16:42:25 2024 +0100
api(Deprecated): Generate always /Deprecated/ annotation with text
Use cmake to remove text when SIP version is less than 6.9.0
commit ed64834106927a43ea072fb3e027d45525bba743
Author: Julien Cabieces <julien.cabieces@oslandia.com>
Date: Mon Dec 16 16:01:17 2024 +0100
api(deprecated): add message to deprecated SIP annotation
commit 92db5c2d824589b9fc2650d03404705b49f1a1af
Author: Julien Cabieces <julien.cabieces@oslandia.com>
Date: Wed Dec 11 17:34:24 2024 +0100
feat(Deprecated): Add message to SIP deprecated annotation
Works only with SIP 6.9.0
commit 398f00bc260c7bbd5b02f9af1f2a472ef093f8d8
Author: Julien Cabieces <julien.cabieces@oslandia.com>
Date: Wed Dec 11 17:33:44 2024 +0100
doc(Deprecated): Fix missing \deprecated instruction
commit 0a42c57a4b67d7c24bbc0a7da2c7c8bc7c4c6b7e
Author: Julien Cabieces <julien.cabieces@oslandia.com>
Date: Wed Dec 11 17:32:10 2024 +0100
build(QSci): fix build when python QSci is missing
commit ca2470bcc3515cfc21e6f560213721b30f4dc947
Merge: 66025ed81d 75758dff03
Author: Alessandro Pasotti <elpaso@itopen.it>
Date: Tue Dec 17 08:36:12 2024 +0100
Merge pull request #59924 from nyalldawson/rename_var
Rename variable for clarity
commit 66025ed81d2d26e4b891db7057264669f6b9edfe
Author: qgis-bot <bot@qgis.org>
Date: Tue Dec 17 02:49:39 2024 +0000
auto sipify 🍺
commit 2adaec6825ee7c18d0c27cda31867b32bcaf7e9d
Author: Jan Caha <jan.caha@outlook.com>
Date: Tue Dec 17 03:46:50 2024 +0100
Mesh Render Extent Settings
This brings to renderer for Mesh Contours option to set renderer Min Max based on extent (specific canvas, changing canvas) in the same way as renderers for Raster Layer.
commit d7e819de383447fed7b1f4ccdbd895c0f7085e5c
Author: Andrea Giudiceandrea <andreaerdna@libero.it>
Date: Tue Dec 17 02:33:45 2024 +0100
[Modeler] Fix algorithms help URL
commit c831a10cc67a026f306cafa2e72ed2f104e64d97
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Dec 17 07:44:07 2024 +1000
Rename test file with typo
commit ebfa41cefa63ff3eb6b7b3b81f151e663017a007
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Dec 17 08:24:51 2024 +1000
Don't write unnecessary attribute to XML when saving point cloud layers
commit 75758dff031fb38d1c194dec0ba7226bd3e651b6
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Dec 17 07:49:42 2024 +1000
Rename variable for clarity
commit 00392397dc983af866ca92bb83b0113a22f6207c
Author: Harrissou Sant-anna <delazj@gmail.com>
Date: Mon Dec 16 17:41:10 2024 +0100
Format alg helpUrl to match actually generated URL
replacing "_" characters by "-"
commit 8c21f8fd605b47e3e03c63675b560f6f277d9892
Author: Jean Felder <jean.felder@oslandia.com>
Date: Mon Dec 16 18:57:17 2024 +0100
qgs3dmapscene: Correctly name elevation ranges variable
This reflects the recent Y/Z coordinate change. The elevation is now
handled by the Z coordinate.
commit 91b473bcfb837d13044b4eb5d1748704e7a1c4c4
Author: qgis-bot <bot@qgis.org>
Date: Mon Dec 16 19:14:16 2024 +0000
auto sipify 🍺
commit 9f4bb3782478edb969600da79340ed4c8623f82a
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Mon Dec 16 12:18:10 2024 +1000
[api] Add QgsVectorDataProvider::geometryColumnName
Allows easy retrieval of the geometry column name from the data
provider, if applicable.
(This was NOT possible to retrieve in a consistent, provider
independant way before)
commit c9981ad10257c803e25bee1918749b4e0a2ff95a
Author: JuhoErvasti <juho.ervasti@gispo.fi>
Date: Mon Dec 16 19:51:06 2024 +0200
Fix split policy test
- This change was made to match the change in b2d4fc8803280a090914026f74b29b150e8f28b5
where the largest geometry is now inherited by the original feature when
splitting features.
- This caused the test to fail for the 'field_unset' and 'field_ratio' attributes
since the largest feature with the largest 'field_ratio' attribute
also had the original 'field_unset' value and the others had an unset
attribute
commit b2d4fc8803280a090914026f74b29b150e8f28b5
Author: JuhoErvasti <juho.ervasti@gispo.fi>
Date: Mon Dec 16 13:22:33 2024 +0200
Split features: always give largest geometry to original feature
commit 4ca5fcb6b5c6da7386f0c2bef448f6f8570b5b6f
Author: qgis-bot <bot@qgis.org>
Date: Mon Dec 16 00:28:52 2024 +0000
auto sipify 🍺
commit 3d4d5a2d022d41ec461df16c7c5f80ed21501b08
Author: Damiano Lombardi <damiano@opengis.ch>
Date: Sun Dec 15 12:01:20 2024 +0100
sipyfy
commit 0b24ef935d05d9fcccd0c6a51b3bdd70f58f58ee
Author: Damiano Lombardi <damiano@opengis.ch>
Date: Sun Dec 15 11:40:32 2024 +0100
Remove layers from the edit buffer group
Layers are removed togheter with removal from project
Fix #59828
commit 72f07dc851e37f11512909f92984c406c0c4eaf0
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Sun Dec 15 08:58:07 2024 +1000
Fix build
commit e4bb317a1b8a954d43f1cff7885f5fac5312da7d
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Sun Dec 15 07:45:18 2024 +1000
Fix some copy instead of move warnings
commit c343317ca10f5939e1f28bb97e35fae8f8018fd8
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Sun Dec 15 07:45:04 2024 +1000
Fix some places we should be using const ref for arguments
commit 551c2c3a60e878f7e220a5a557d790a750fd8066
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Sun Dec 15 07:44:11 2024 +1000
Fix coverity dereference after nullptr check warning
commit 49972ac2d7d153098372a161020b90e855967fcd
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Sun Dec 15 07:44:04 2024 +1000
Fix coverity dereference after nullptr check warning
commit 9f496a8d082908d9f54ba313971fd75fd772ce57
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Sun Dec 15 07:43:29 2024 +1000
Fix coverity unchecked cast warning
commit ea4c3f670bfb6eb7f8aab8c50c90c617971b9344
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Sat Dec 14 16:16:14 2024 +1000
Fix coverity copy instead of move warning
commit 1026d287c629595cc6b2fbef16c374b76922eb48
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Sat Dec 14 16:13:09 2024 +1000
Initialize member
commit 407de5fc10176eacdfbb339d8f98b15f83115fa2
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Sat Dec 14 16:12:55 2024 +1000
Document intentional hack
commit 74623016aa63b5d7960d15f6442d861b2bbe9b52
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Sat Dec 14 16:07:25 2024 +1000
Fix coverity nullptr dereference error
commit 40ed3291ec89dc07b9e40c575fab4e869eacac8b
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Sat Dec 14 16:06:29 2024 +1000
Fix coverity copy instead of move warning
commit 093d55cfd132384e4bb03f06c217226c1e1ee512
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Sat Dec 14 16:01:53 2024 +1000
Fix coverity nullptr dereference warning, leak, inefficiency
commit 94b12d2e7e1034333fa7436a2c591d8912af9575
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Sat Dec 14 15:54:58 2024 +1000
Fix coverity copy instead of move warning
commit aee1ed357d184af0d4cb8401ef31b4e970cfd383
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Sat Dec 14 15:54:47 2024 +1000
Avoid false-positive coverity warning
commit daf39ab46b347a3ae08eb425f2cdb760970a48d2
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Sat Dec 14 15:49:02 2024 +1000
Fix coverity copy instead of move warning
commit ea2a2b68cbcdbc092a14cddc264a9258068d2ba2
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Sat Dec 14 15:45:27 2024 +1000
Fix dereference after null check error in concave hull algorithm
commit a9a74e9aed650744aca0f81dc771b4b73b8f6cfe
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Sat Dec 14 19:05:03 2024 +1000
Fix heatmap algorithm on qt6
commit cea29feecf26915f1bf8fb9bac8442ebd20a9e77
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Sat Dec 14 17:31:50 2024 +1000
Enable a test on qt 6 builds
commit 86978d503f2f4a75bd853c36279eaa3760d5ec16
Merge: 5737c9808c 442f317bf1
Author: Matthias Kuhn <matthias@opengis.ch>
Date: Sat Dec 14 09:22:04 2024 +0100
Merge pull request #59895 from nyalldawson/no_moc
Don't include moc for non QObject classes
commit 442f317bf15ad50896e9fc477e5094798eb5831b
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Sat Dec 14 15:40:29 2024 +1000
Don't include moc for non QObject classes
commit 5737c9808cd696d29fd5f6af27882ddf8eeba798
Author: t0b3 <thomas.bettler@gmail.com>
Date: Fri Dec 13 08:55:01 2024 +0100
fix: libaio on noble is incompatible for oracle client
see https://bugs.launchpad.net/ubuntu/+source/libaio/+bug/2067501
commit 59a76430dc384b1a1fb06ffd0c0958c64434a2ef
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Sat Dec 14 08:24:08 2024 +1000
Fix cppcheck errors
commit 7c65196b9f50eee64874a9f22edef62e901861f5
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Sat Dec 14 08:31:14 2024 +1000
Test still fails on qt6 on ci (but passes locally!)
commit 3d2f37a756c2706e09e3f1dd736db30306752bb0
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Fri Dec 13 08:40:15 2024 +1000
Fix test which was never working, but just skipped on CI because too old GDAL
commit 05c269d61de05c796376ccabddf2da5bb1b8c2a1
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Fri Dec 13 08:39:47 2024 +1000
Fix test on newer GEOS versions
commit 524a8b00ece3b89de420a6db395815507ecff8e3
Author: t0b3 <thomas.bettler@gmail.com>
Date: Thu Dec 12 23:15:16 2024 +0100
doc: fix path
commit ecfc45116074fa129c202173faa1c43dc934e358
Author: Denis Rouzaud <denis.rouzaud@gmail.com>
Date: Fri Dec 13 08:16:45 2024 +0100
clang-format SpacesInAngles: Leave
commit b524995a69f93b2efa844f94da0ddbdb646987bf
Merge: 8edbf86d8e c2d213d339
Author: Alexander Bruy <alexander.bruy@gmail.com>
Date: Fri Dec 13 12:55:49 2024 +0000
Merge pull request #59864 from nyalldawson/fix_server_crash
Fix crash in server VirtualErrorHandler on newer sip environments
commit 8edbf86d8e10a29468ea32df0e31f1cb930ce3c6
Merge: 83761ee828 a9a0f455e2
Author: Alexander Bruy <alexander.bruy@gmail.com>
Date: Fri Dec 13 08:17:16 2024 +0000
Merge pull request #59874 from nyalldawson/fix_hang_server_security
Fix hang on server security test on Fedora
commit 83761ee8280620f0b13e2675d23d39fb4f2d7d73
Merge: 645c474284 5a0886151c
Author: Alexander Bruy <alexander.bruy@gmail.com>
Date: Fri Dec 13 08:16:15 2024 +0000
Merge pull request #59872 from nyalldawson/test_mask_wms
Fix server wms test on Fedora 41
commit 645c474284675e2a71b91451a913c22f67d94c2b
Author: qgis-bot <bot@qgis.org>
Date: Fri Dec 13 04:24:36 2024 +0000
auto sipify 🍺
commit fe4e900a7365cb915da01dd3f8a851d24441f6c3
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 12 13:15:51 2024 +1000
Fix clang-tidy warnings
commit cd63b0f1cb50e7ea15569f134aadf8e50d4065a9
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 12 10:40:23 2024 +1000
Fix copy of Qgs3DRenderContext
commit 495047d3281e2b5823ee0e0abad2c91d6dbd9491
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 12 10:39:06 2024 +1000
Style
commit 3a649fbc817f6bbb6cdb6ef0e5c78489fd1a716e
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 12 10:37:58 2024 +1000
Rename file to qgsabstractterrainsettings.h/cpp
commit 821a8269925fb647f66406e9ade645a5741011e5
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 12 10:03:08 2024 +1000
Fix windows build
commit 884e0b0ca61ad17138e9ec81e8a9b36f562ec3c5
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 12 10:01:07 2024 +1000
Remove broken seealso
commit d0481d06da6ba99582a1542615cc0038106923cf
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 12 10:00:06 2024 +1000
Remove deprecated call
commit d1ec9615cc899b1327087b7924ee94d9207b286d
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 11 16:27:28 2024 +1000
Fix terrain after loading project
commit ebe81e24f8fee195697a6429bd6050e67c05b6f4
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 11 15:21:10 2024 +1000
Replace deprecated methods in tests
commit 5597b316a6336bc6348d16f4d0c0560238d96dff
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 11 15:08:37 2024 +1000
Fix restoring old projects
commit 181bc91fbcc1588516814fc80288ef3631dc7371
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 11 14:54:31 2024 +1000
Update GUI to use terrain settings
commit 537d16af60bf2d1ddad46cea5f626d7c210c66d5
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 11 14:28:39 2024 +1000
Remove resolveReferences from terrain generators
commit 6019c3e75514134ef6cf889b02f97b972dfe70eb
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Nov 26 15:32:43 2024 +1000
Handle extent and crs in terrain generator creation
commit f9f2aa40f020720e4f454cfe8e0b81b5ecc08df9
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Nov 26 15:32:25 2024 +1000
Move symbol to QgsMeshTerrainSettings
commit a1cfb3ff106391ceda4aa7f9066a614398be5274
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Nov 26 14:16:05 2024 +1000
Start removing read/writeXml from generators
commit e550ea7670a42a8690ca50e4dcb424662ed50c87
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Nov 26 13:46:19 2024 +1000
Move configurateTerrainFromProject to registry
commit be19042d1dfe2eeb6bf8d5470a2306325c21bb27
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Nov 26 13:46:04 2024 +1000
Terrain settings can create generators
commit 64e0c9e4846a41d6782b47a100b2badd022e470d
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Nov 26 13:06:45 2024 +1000
Use registry to create terrain generator
commit 25313dd530c0bbc7397765232f5ed2b367bdc476
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Nov 26 12:53:50 2024 +1000
Registry can create terrain generators
commit c1bd66a54d90ffe859bb1ed6ae5c1b9b3a34297f
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Nov 26 12:45:12 2024 +1000
Online DEM
commit ed9b2784b02be28e572263072c841f1dfdf1598e
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Nov 26 12:36:48 2024 +1000
Quantized mesh settings
commit 293b7afadd521a2a1c5e577dad3ce8b6190de14e
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Tue Nov 26 11:59:13 2024 +1000
Implement a registry for terrain objects
commit 8af23b10024be91a8e97a81832907393544a7fd5
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Aug 15 11:15:03 2024 +1000
Initial framework for terrain settings refactoring
commit befc78e3f508b036c99ae9819530d8bcb1304e95
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Fri Dec 13 10:32:09 2024 +1000
Run oauth2 python test on qt6 builds
commit 27253e1c215cc116bd5d8dae15157f05cc1a65db
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Fri Dec 13 09:59:46 2024 +1000
Fix test on newer python
commit 2eab01c280c4f60c44eb15be87bdb7b9775d2e72
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Fri Dec 13 10:10:03 2024 +1000
Add test mask for processing result
We don't need to care too much about font rendering issues here, we are just testing that the output is generated
commit 9dce569f9310885a08abc8695e8b3837fcf27831
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Fri Dec 13 10:14:53 2024 +1000
Fix fragileness in test if run after some other tests
commit 8c3017b0b22af1a36a98154deab8cd2ea60521df
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Fri Dec 13 10:18:42 2024 +1000
Fix test on newer python versions
commit a9a0f455e2a01a49e22cad5e15b20826bfafe545
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Fri Dec 13 10:47:38 2024 +1000
Fix hang on server security test on Fedora
We were incorrectly creating two instances of QgsApplication
commit 5a0886151c085981a4fb55a10bbaca71acf8bdfe
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Fri Dec 13 10:23:32 2024 +1000
Use correct test font in test
commit b9fef9ddd82b87c9bd4291a3ebd55544ec48695b
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Fri Dec 13 10:20:04 2024 +1000
Add test mask
commit f7c0a8d5ee37c15acc3fd092984ed36911cfdeba
Author: qgis-bot <bot@qgis.org>
Date: Thu Dec 12 23:40:48 2024 +0000
auto sipify 🍺
commit 2f2e900098cbffc53e0a9cc77f6bfdf1a3b8ac69
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Fri Dec 13 07:54:45 2024 +1000
Add api to control spin box editing timeout interval
commit 0f64fdfeb9132c462aae17a8265df1fd7cab7069
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Mon Dec 9 13:20:55 2024 +1000
Add editingTimeout signal to Qgs(Double)SpinBox
Emitted when either:
1. 2 seconds has elapsed since the last value change in the widget
(eg last key press or scroll wheel event)
2. or, immediately after the widget has lost focus after its value
was changed.
This signal can be used to respond semi-instantly to changes in
the spin box, without responding too quickly
while the user in the middle of setting the value.
commit b463e7c8131d9cd9df36cb31a7093db2a20c6048
Author: Jan Caha <jan.caha@outlook.com>
Date: Thu Dec 12 14:32:44 2024 +0100
fix error where table comment was not updated on second open of "Table Properties" window
commit 330c03dccc64fb759398feae42522294023f5382
Author: Jan Caha <jan.caha@outlook.com>
Date: Thu Dec 12 14:31:30 2024 +0100
edit QLineEdit to QTextEdit
commit c2d213d3394095b47c7c2866523a169aeb7da75f
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Fri Dec 13 08:21:11 2024 +1000
Fix crash in server VirtualErrorHandler on newer sip environments
Fixes crash in tests, and adapts these VirtualErrorHandlers to the same
code used elsewhere in QGIS
commit 6dc88e691014d96c243e7b6e03413918133db897
Author: Yoann Quenach de Quivillic <yoann.quenach@gmail.com>
Date: Thu Dec 12 14:39:07 2024 +0100
Apply suggestions from code review
commit 6c3dc5d069c639831c22f228b008ee599e541f3f
Author: Yoann Quenach de Quivillic <yoann.quenach@gmail.com>
Date: Sat Dec 7 15:13:38 2024 +0100
Temporary rubberband
commit 7141c2e3683946abdaf4e5f4fdb126ea0addaca9
Author: Yoann Quenach de Quivillic <yoann.quenach@gmail.com>
Date: Sun Oct 27 22:26:38 2024 +0100
Add antialiasing flag to layoutView
commit ee30ddac8a56b18b5320b301e32d2db0c84511a9
Author: Yoann Quenach de Quivillic <yoann.quenach@gmail.com>
Date: Sun Oct 27 14:56:37 2024 +0100
Updating rubber band when deleting last node
commit 0b9007536fb7dc95c8c7de93cc4830b54ef05cc3
Author: Yoann Quenach de Quivillic <yoann.quenach@gmail.com>
Date: Sun Oct 27 14:56:09 2024 +0100
Diable delete and backspace shortcuts while ading node item
commit 712e631a8527af3c41bd3d0caa73df8c965ef85a
Author: Yoann Quenach de Quivillic <yoann.quenach@gmail.com>
Date: Sun Oct 27 14:54:54 2024 +0100
Deselect current item when adding a new item
commit 26b8235007d07ab22b74866b91dc7c6f2ba42487
Author: Yoann Quenach de Quivillic <yoann.quenach@gmail.com>
Date: Thu Dec 12 12:16:09 2024 +0100
Add test
commit 3c3a7f9324096f9b110ba14559a084b3d80e2543
Author: Yoann Quenach de Quivillic <yoann.quenach@gmail.com>
Date: Tue Dec 3 11:51:12 2024 +0100
Fix common angles guide line flickering
commit e41c2968a0abfb993859b3d7ef72bf8655f17712
Author: Denis Rouzaud <denis.rouzaud@gmail.com>
Date: Thu Dec 12 21:23:30 2024 +0100
fix build (#59856)
commit cd2657e7795737105e60f83c404a8e036dde1044
Author: Denis Rouzaud <denis.rouzaud@gmail.com>
Date: Thu Dec 12 16:25:38 2024 +0100
cleanup sipify-bot.yml
commit 71646577a59aeac02a3cae15ac9262cc0b7015f4
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 12 17:21:41 2024 +1000
Run test on qt 6 builds
commit fdf67ef279b5f4065005038037d01b3c4443cae6
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 12 17:21:11 2024 +1000
Fix leak, crash on Qt 6 builds
commit d593aebd03ba0f77e3e49c1bd1a97ae46534b452
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 12 17:20:52 2024 +1000
fixup
commit e8cbab70348dbc2cb3288f39798b6bd1a3af5fea
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 12 17:20:37 2024 +1000
Add missing transfer annotations
commit 06c938b6ac92abe2e6639e4efeb405d4c7fd7a73
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 12 15:56:14 2024 +1000
Fix test on newer geos
Add more tolerance to calculated part split lengths
commit 1f080b9a1075e49a7d00f19c0415339be0f07765
Merge: fb501d5734 7dbd894c8e
Author: Julien Cabieces <julien.cabieces@oslandia.com>
Date: Thu Dec 12 17:00:05 2024 +0100
Merge pull request #59844 from nyalldawson/fix_blocking_process_test
Fix blocking process test
commit fb501d573438bd6c68467638c6b9955f90914fab
Merge: 4d47ba40af 954d54a53d
Author: Julien Cabieces <julien.cabieces@oslandia.com>
Date: Thu Dec 12 14:30:03 2024 +0100
Merge pull request #59846 from t0b3/upgrade-oracle-client
CI: upgrade oracle client binaries
commit 4d47ba40afeac5f7f39b70470e299a3a4f6eb314
Author: qgis-bot <bot@qgis.org>
Date: Thu Dec 12 08:42:35 2024 +0000
auto sipify 🍺
commit 60d133c80e1a196b1894ca5e07016feb5a55a719
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 12 11:50:36 2024 +1000
Fix test on qt6
commit 55a598668720fce84c4c724342afc7c208214742
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 12 09:39:52 2024 +1000
When a sufficiently long crs filter string is entered, auto expand all groups
Makes it much less annoying to find a crs by string!
commit ae92a28ae5154128ad7ef26321b2431428b1c968
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 12 09:34:21 2024 +1000
Use word based search when filtering CRS
So that typing eg "world winkel" will show the "World_Winkel_Tripel_NGS"
CRS
commit 1adfe87fe83f2ee2e7499b67a5ce91b313973faf
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 12 09:27:52 2024 +1000
Add CRS group name and projection name to CRS model data
commit 0fff1f16b4ae84410bc8e4f0aff0deb431acf412
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 12 09:24:48 2024 +1000
Add QgsStringUtils.containsByWord method
Given a candidate string, returns true if the candidate contains
all the individual words from another string, regardless of their order.
commit 7dbd894c8e365b5065e48d5e9a1d88b615aaaf9b
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 12 17:47:43 2024 +1000
Ignore LC_ALL: cannot change locale when testing std output
commit 954d54a53dae2f5fb3773457099614e483b60a98
Author: t0b3 <thomas.bettler@gmail.com>
Date: Wed Dec 11 22:17:17 2024 +0100
CI: upgrade oracle binaries
commit 887d3f61211b00ff38077e3ef4340bce4a766f28
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 12 15:51:58 2024 +1000
Run test on qt 6 builds
commit cd68294613929bbf8f55d7851cc552fc6a98bc8f
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Thu Dec 12 15:51:22 2024 +1000
Don't rely on specific ogrinfo outputs in test
Makes tests robust to different gdal versions
commit eab9636fa543a78f1b12895590e30298fe90e76f
Author: Yoann Quenach de Quivillic <yoann.quenach@gmail.com>
Date: Tue Dec 3 16:43:43 2024 +0100
Add tooltip
commit 49777cebb935f662e1d16b8e4565e0a11d411d9b
Author: Yoann Quenach de Quivillic <yoann.quenach@gmail.com>
Date: Tue Dec 3 15:58:40 2024 +0100
Add test
commit 6f824ec5fac286cd133ac3b35870d75ae2b1a1f1
Author: Yoann Quenach de Quivillic <yoann.quenach@gmail.com>
Date: Sun Dec 1 00:15:11 2024 +0100
Multi trim extend
commit 354f9358ee60775b0d2fbf3b84df3fd089b88781
Author: t0b3 <thomas.bettler@gmail.com>
Date: Wed Dec 11 23:02:13 2024 +0100
yarn upgrade
commit 85dc8b0cfc4fc0dce2b57dfc6dd14d9c7162b5b9
Author: t0b3 <thomas.bettler@gmail.com>
Date: Wed Dec 11 22:48:58 2024 +0100
CI: upgrade to nodejs v22
commit 3ff6ca6556252f5bff4989201f16513c5c52edae
Author: Harrissou Sant-anna <delazj@gmail.com>
Date: Wed Dec 11 23:02:58 2024 +0100
Remove optional flag next to Processing algs Boolean parameters - fixes #59794
commit f5447dc61b06b046f3d8628bdbfd555add7cec95
Author: Julien Cabieces <julien.cabieces@oslandia.com>
Date: Wed Dec 11 18:12:18 2024 +0100
license(CMYK): Add CMYK ICC profile test file
commit 3474706d395cca3961a30e5fed46111a14fbd46d
Author: Julien Cabieces <julien.cabieces@oslandia.com>
Date: Tue Dec 10 09:00:38 2024 +0100
fix(CMYK): add missing test file
Regarding the license, the file can be used, embedded, exchanged, and
shared without restriction. see
https://www.color.org/registry/CGATS21_CRPC6.xalter.
commit 2f93be8f8674d1354cf7684751da76fc6f666671
Merge: c919edc87c 3cbabfcc1e
Author: Matthias Kuhn <matthias@opengis.ch>
Date: Wed Dec 11 21:00:35 2024 +0100
Merge pull request #59831 from m-kuhn/polynameoursity
[relations] Show polymorphic relation name in config dialog
commit c919edc87cffd4eb7f08245a4677bdb79a837703
Merge: 2601265871 8d23d9f54b
Author: Julien Cabieces <julien.cabieces@oslandia.com>
Date: Wed Dec 11 19:12:26 2024 +0100
Merge pull request #59829 from lindacamathias/patch-1
Fix table of content in readme
commit 26012658710b1cfb3df58d19255c786917f0b527
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 11 16:34:42 2024 +1000
Fix an instance where the status bar coordinates are incorrectly transformed
This can happen immediately after a project CRS change, as the last
mouse coordinates are incorrectly considered to be in the new
project CRS.
commit 53c40895530030c1b47eeddb8ef1dbb3fc716105
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 11 16:33:44 2024 +1000
When an error in a fallback operation occurs, ensure exception has correct input coordinates
It was showing the inf/inf values from the failed transform, not the
input coordinate
commit fdc24b26ed8aeb26d36f82a9c8918ee5c77491c4
Author: Damiano Lombardi <damiano@opengis.ch>
Date: Wed Dec 11 17:07:27 2024 +0100
Set additional HTTP headers for WCS provider (#59635)
* Set additional HTTP headers for WCS provider
Same way as done for WMS
Fixes partially #17823 (WFS still missing)
* Move qgsauthorizationsettings.h to core/auth
* qgsauthorizationsettings.h SIP_NO_FILE
* Add class documentation
* Add CORE_EXPORT
* switcht to class
* Move implementation to cpp file
* fix indentation
---------
Co-authored-by: Denis Rouzaud <denis.rouzaud@gmail.com>
commit 3cbabfcc1ef7abd40771c8246b8df9b39ad6c4f3
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date: Wed Dec 11 15:31:31 2024 +0000
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
commit 79e1996f225055ef7bb84142bb3546116f817641
Author: Matthias Kuhn <matthias@opengis.ch>
Date: Wed Dec 11 16:25:40 2024 +0100
[relations] Show polymorphic relation name in config dialog
commit b6e18bbff78d52b24d20f94628070b432fb13f03
Author: qgis-bot <bot@qgis.org>
Date: Wed Dec 11 14:57:52 2024 +0000
auto sipify 🍺
commit ea95dfafda92aa9fb94b15c06aa19a4fb4d51707
Merge: 5e4ff38a82 cfc2418675
Author: Julien Cabieces <julien.cabieces@oslandia.com>
Date: Wed Dec 11 15:55:09 2024 +0100
Merge pull request #59809 from ptitjano/elevation-profile-raster-load
[elevation Profile] Correcly add a raster layer to an existing elevation profile widget
commit 8d23d9f54b330969373f82b43cb5808a24f2cf79
Author: Linda Camathias <77726342+lindacamathias@users.noreply.github.com>
Date: Wed Dec 11 15:19:20 2024 +0100
Fix table of content in readme
commit 5e4ff38a82915f5e24230ea74d43e21992846c28
Author: qgis-bot <bot@qgis.org>
Date: Wed Dec 11 14:09:01 2024 +0000
auto sipify 🍺
commit 254614b393a277510ed77989338c0e41dd1dcd37
Author: Jan Caha <jan.caha@outlook.com>
Date: Wed Dec 11 15:06:17 2024 +0100
Mesh layer remove datasetgroup (#59382)
* add removeDatasetGroup() function for mesh data provider and mesh layer
* make dataset group names unique
* fix typo
* add mesh removing to the widget
* fix icon
* add check that added dataset group path is unique to avoid duplicate data and emit message if it is not
* sipify
* fix mistake
* check if uri is correct - just for case
* add tests
* add tests
* fix docstring
* add docstring
* add missing override
* explicitly convert number to string
* update tests to reflect that you cannot add same file as dataset group twice
* fix docstring
* pass by value
* fix docstrings
* const variables
* rename signal
* drop include
* simplify regex
* make test better
* sipify
* add docstring
* fix styling and typo
* fix tests
* fix precommit issues
* fix issue
* Update src/core/mesh/qgsmeshlayer.h
fix docstring
Co-authored-by: Stefanos Natsis <uclaros@gmail.com>
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* const stuff
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* sipify
---------
Co-authored-by: Stefanos Natsis <uclaros@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
commit f593da593ab02fb20eaccf0ceccf64d80b0ad90b
Author: Jan Caha <jan.caha@outlook.com>
Date: Wed Dec 11 15:04:48 2024 +0100
New Algorithm - Mesh Surface to Polygon (#58941)
* new algorithm
* update feedback
* allow cancel during mesh face processing
* allow cancel during mesh faces processing
* fix file names
* fix the speed of the algorithm
* drop not needed imports
* fix issues
* more readable
* add mesh layer
* test case
* simplify to avoid warning
* fix issue
* fix data call
* fix call
* fix expected data
* handle meshes with holes
* add test case
* merge from master
* Update src/analysis/processing/qgsalgorithmmeshsurfacetopolygon.cpp
fix translation
Co-authored-by: Stefanos Natsis <uclaros@gmail.com>
* Update src/analysis/processing/qgsalgorithmmeshsurfacetopolygon.cpp
fix translation
Co-authored-by: Stefanos Natsis <uclaros@gmail.com>
* Update src/analysis/processing/qgsalgorithmmeshsurfacetopolygon.cpp
fix translation
Co-authored-by: Stefanos Natsis <uclaros@gmail.com>
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* fix translation
* typo
* clone
* delete to avoid memory leak
---------
Co-authored-by: Stefanos Natsis <uclaros@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
commit baed5b01d67a24e2dea7bcda3ff883d3d79aea83
Author: Jan Caha <jan.caha@outlook.com>
Date: Wed Dec 11 15:03:36 2024 +0100
Mesh point add elevation (#58877)
* select separate mesh point after adding it
* applyZValueFromProjectTerrainOnSelectedVertices function
* add stuff to widget and connect with the tool
* if the transform fails use original coordinates
* rename function
* review suggestions
* styling fixes
* fix clang-tidy issues
* add tests
* if terrain provider value is NaN, default value should be set, using currentZValue() would set up last added Z value (from previous point for example)
* more test cases
* one more test
* add message bar warning if default value is used
* move from z widget to separate settings and offer more flexibility
* move from z value widget to QgsMeshTransformCoordinatesDockWidget
* update tests to reflect changes
* fix tests
* revert QgsZValueWidget back to its original state
* avoid issue
* move currentZValue() up in the logic to avoid clang error
* release terrain providers to avoid SEGFAULT
* fix precommit issues
* fix precommit issue
* drop empty line
* Update src/app/mesh/qgsmaptooleditmeshframe.cpp
add tooltips, change names
Co-authored-by: Stefanos Natsis <uclaros@gmail.com>
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* rename enum
* rename setting
* drop leftover
* use default timing
* rename function
* change setting value, to work with changed order
* update tests
---------
Co-authored-by: Stefanos Natsis <uclaros@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
commit 21450c1223d73a0407a23c939c62f00d97fc3756
Author: qgis-bot <bot@qgis.org>
Date: Wed Dec 11 13:57:37 2024 +0000
auto sipify 🍺
commit 0baab445c083fd0120127ab98c8caae15b238019
Merge: 992ccc9293 737db66248
Author: Alexander Bruy <alexander.bruy@gmail.com>
Date: Wed Dec 11 13:54:56 2024 +0000
Merge pull request #59813 from nyalldawson/coverity
Coverity scan fixes
commit cfc2418675afab5cca50663758cef0785f20139d
Author: Jean Felder <jean.felder@oslandia.com>
Date: Wed Dec 11 11:02:35 2024 +0100
qgslayertreemodel: Fix layerFlagsChanged docstring
commit 0fb39fe99d493ffb6eb7a8275e195dae8ff4e73e
Author: Jean Felder <jean.felder@oslandia.com>
Date: Tue Dec 10 18:08:29 2024 +0100
qgslayertreemodel: Ensure to refresh when elevation properties change
If an elevation profile widget is already open, when a new raster
layer is added, it is not added to the elevation widget
treeview. Indeed, when a new raster is added,
`QgsRasterLayer::elevationProperties::hasElevation()` returns `False`
by default and the proxy model of the elevation filters out the layers
which do not have an elevation.
Later on, `QgsAppLayerHandling::postProcessAddedLayer` is called on
this raster and it sets the elevation to `True` if it looks like a
DEM (See
`QgsRasterLayerElevationProperties::layerLooksLikeDem()`). However,
the layer tree of the elevation widget has already been populated and
it is not updated.
This issue is fixed by emitting the the `dataChanged` signal every
time the elevation properties of a layer changes. Indeed, this forces
a full refresh of the model and displays the raster in that case.
commit 992ccc929398b39cd8d1a2ae223da3b4449a3fdf
Author: qgis-bot <bot@qgis.org>
Date: Wed Dec 11 09:42:27 2024 +0000
auto sipify 🍺
commit 2b055eb8071ed1b3ee34acda64cfeaffa83a20c8
Author: Denis Rouzaud <denis.rouzaud@gmail.com>
Date: Wed Dec 11 10:39:45 2024 +0100
add an option to define locator tree height (#59825)
* add an option to define locator tree height
* add comment that it requires a restart
commit f4975103b6c3b3b4d0cf871ad51d336ecc84008f
Author: qgis-bot <bot@qgis.org>
Date: Wed Dec 11 09:22:49 2024 +0000
auto sipify 🍺
commit 7672b3509b5dc8f1ce99674be81933d964d01093
Author: Denis Rouzaud <denis.rouzaud@gmail.com>
Date: Wed Dec 11 10:20:06 2024 +0100
Update .git-blame-ignore-revs with clang-format 3d/server
commit 17574346e1fe7638f72e6387b733c8b7457d5e8a
Merge: 2fc40b845c 76c6fff98f
Author: Denis Rouzaud <denis.rouzaud@gmail.com>
Date: Wed Dec 11 10:19:05 2024 +0100
Merge pull request #59805 from 3nids/more-clang
clang-format on 3d and server
commit 2fc40b845cfceccfc5c5759adddb498bd1ad29f6
Author: qgis-bot <bot@qgis.org>
Date: Wed Dec 11 09:14:31 2024 +0000
auto sipify 🍺
commit 22fe235648853399acdcdfec7dd5125c573af1fb
Author: Matej Bagar <matej.bagar@lutraconsulting.co.uk>
Date: Wed Dec 11 09:11:44 2024 +0000
Virtual point clouds - Tile Labels (#59726)
* Add label rendering into VPC tiles
* Move tile labels rendering into QgsPointCloudExtentRenderer
* Rework showLabels flag once more & connect it to widget
* Add widget for label TextFormat WIP
* Rework and fix text format widget issues
* Improve default text format used in VPC labels
* Fix banned keywords issue
* Fix QgsTextFormat review issue
* Fix labels drawing efficiency issue
* Fix formating issues
* Fix review issues
commit 76c6fff98f0e49866c7f98b9a62438180a227bb3
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date: Wed Dec 11 06:55:30 2024 +0000
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
commit 7306e5b170eb85e4e5f52d80e774e05f11459a0d
Merge: 30ea619861 62034dfe30
Author: Denis Rouzaud <denis.rouzaud@gmail.com>
Date: Wed Dec 11 07:53:23 2024 +0100
Merge branch 'master' into more-clang
commit 62034dfe30abf31dc1c89f800dda266b9cfd8490
Merge: 99fc870dad 1b64471d2b
Author: Alessandro Pasotti <elpaso@itopen.it>
Date: Wed Dec 11 07:44:01 2024 +0100
Merge pull request #59477 from elpaso/bugfix-gh59408-partial-fix-for-overlay_intersects_details
overlay_intersects: flatten collections and filter by type
commit 99fc870dadac48da2ce2ed93120bdfbec78f2697
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 11 09:25:04 2024 +1000
Don't allow "fixed time range per band" when raster has multi-band symbology
Fixes #59777
Just like the equivalent fixed-elevation-range per band mode for
elevation, this temporal setting ONLY makes sense when the renderer
is a single-band renderer.
commit 1dd6a4ac720335f186eb41ddc868d011c89a4255
Merge: ab1fba8ce1 b9f1da5b8e
Author: Matthias Kuhn <matthias@opengis.ch>
Date: Wed Dec 11 07:34:21 2024 +0100
Merge pull request #59769 from sebastic/appstream
Fix AppStream metadata.
commit ab1fba8ce153d05b38f53b4a1854b9545a634ee3
Merge: 313873d58e 42e044ca4f
Author: Matthias Kuhn <matthias@opengis.ch>
Date: Wed Dec 11 07:01:11 2024 +0100
Merge pull request #59800 from m-kuhn/external_o2
Use o2 library from https://github.com/qgis/o2/
commit 313873d58e36189bbd7484d809625104baff02c7
Author: Matt Fisher <mfisher87@gmail.com>
Date: Tue Dec 10 19:52:41 2024 -0700
Regenerate SIP files
commit bcf3bb4c968e66d260b23d076aa4ab819ce261c8
Author: Matt Fisher <3608264+mfisher87@users.noreply.github.com>
Date: Tue Dec 10 11:15:23 2024 -0700
Fix mistake in docstring for `QgsProjectMetadata`
I believe the first sentence here was copied from `QgsLayerMetadata`.
commit 0811b32696856dcce70e2d270a47f81572e2251e
Author: Etienne Trimaille <gustrimaille@yahoo.fr>
Date: Tue Dec 10 19:40:13 2024 +0100
Model to Python script - Add annotations
commit 6f4304bc0e43a7ce9f7f015efda92a8e165fc956
Author: Etienne Trimaille <gustrimaille@yahoo.fr>
Date: Tue Dec 10 19:11:56 2024 +0100
Review the Processing script template : add annotations, remove self.tr
commit 0369b04affd95f2af1d36e52c1c0350f27c749ca
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 11 08:17:18 2024 +1000
Test masks for Ubuntu 24.04
commit 737db66248e16ef864afe2a0e962678d1d0c811c
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 11 07:53:04 2024 +1000
Add missing docs
commit 53ceb208932b1ba6d1793d1d0e630d061fead421
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 11 06:40:14 2024 +1000
Fix coverity unchecked return value warning, improve docs
commit cadf4ae455f97826492af821a5f9707b2a086f8f
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 11 06:37:43 2024 +1000
Pass by const ref
commit 351f2c26e5dc5f397672944cae5706f84bdd9c22
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 11 06:35:20 2024 +1000
Fix some coverity unchecked return value warnings
commit 1070f7544b560423aae04ad8e11f53004b7b2f01
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 11 06:26:49 2024 +1000
Fix coverity COPY_INSTEAD_OF_MOVE warning
commit 54c25b079115ca6f2fa35ea30d48568f78479fb9
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 11 06:24:24 2024 +1000
Use const ref
commit 785a968f47adff50afa9bbe31046848464e2c7e8
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date: Wed Dec 11 06:21:58 2024 +1000
Fix coverity issues in QgsStacSourceSelect::showItemsContextMenu
- Unchecked dynamic_cast
- Fix access to temporary reference from lambda slot
commit 98c5bf8bcd32125739cdf10e8a7502bd5e4c7f35
Author: qgis-bot <bot@qgis.org>
Date: Tue Dec 10 15:43:17 2024 +0000
auto sipify 🍺
commit 2391d895f2d8993453437f7e9b89fa69c5f9c583
Author: uclaros <uclaros@gmail.com>
Date: Tue Dec 10 15:19:02 2024 +0200
address review issues
commit b4a63ee2bc12317c3723358f777d778c671530ec
Author: uclaros <uclaros@gmail.com>
Date: Fri Dec 6 16:43:15 2024 +0200
Highlight identified point cloud points in 3d views
commit 30ea619861be7b3f40fba23330b566e587e44ed5
Author: Denis Rouzaud <denis.rouzaud@gmail.com>
Date: Tue Dec 10 14:52:35 2024 +0100
sipify
commit 3a4f8bcdad4f843d7217116ac1cb94b6b6c3fb8b
Author: Denis Rouzaud <denis.rouzaud@gmail.com>
Date: Tue Dec 10 14:41:57 2024 +0100
run clang-format on 3d + server
commit eef2e2045f0130dcf9843175a06f449240b66556
Author: Denis Rouzaud <denis.rouzaud@gmail.com>
Date: Tue Dec 10 14:22:51 2024 +0100
add server and 3d to clang-format
commit 42e044ca4fed4e842f29637a37886bd0f2ead776
Author: Matthias Kuhn <matthias@opengis.ch>
Date: Tue Dec 10 11:37:45 2024 +0100
Sync o2
commit d255d21eff718785b1146b4232b151eeff54e9e9
Author: Matthias Kuhn <matthias@opengis.ch>
Date: Tue Dec 10 09:19:35 2024 +0100
Use o2 library from https://github.com/qgis/o2/
commit d1de2574de2fddb588182d6cb7a5dc87ce30dde4
Author: Sebastian Gutwein <bas@rdgland.com>
Date: Mon Dec 9 19:39:06 2024 -0500
round three tweaks
commit 1e688c07577df7b037e8e1aab877e6bd821f69b4
Author: Sebastian Gutwein <bas@rdgland.com>
Date: Fri Nov 22 22:25:40 2024 -0500
Add description and normal operation to hints
commit c028aa6e2356f788c040bef76fc7cc712fd8bdfe
Author: Sebastian Gutwein <bas@rdgland.com>
Date: Mon Nov 11 13:41:51 2024 -0500
Add options to Offset Curve and Fill Ring Help Text
Adds modifiers to help text for offset curve and fill ring advanced digitizing tools.
commit 2ad19b4b48ab2fa32e79e14ad12a77659e003064
Author: qgis-bot <bot@qgis.org>
Date: Mon Dec 9 23:59:38 2024 +0000
auto sipify 🍺
commit c130eb7c3d02e9a5df03baddf92a57c861ae8b42
Author: JuhoErvasti <juho.ervasti@gispo.fi>
Date: Mon Dec 9 23:10:46 2024 +0200
Add \since to new functions
commit 795a79204600694d8a95667c73fa223c419cf329
Author: Juho Ervasti <juho.ervasti@gispo.fi>
Date: Mon Dec 9 16:01:15 2024 +0200
Fix format
commit b373c8b3aacd3fe2d383b9bc581907da69e7b18e
Author: JuhoErvasti <juho.ervasti@gispo.fi>
Date: Mon Dec 9 11:43:28 2024 +0200
Address review
commit e01247566c28232f1aa8ce7d68ff17cc40714e53
Author: Juho Ervasti <juho.ervasti@gispo.fi>
Date: Thu Dec 5 19:34:42 2024 +0200
Check extent buffer size unit in tests
commit 6b6a4d554954ef03f05beb53f4f187aa17465990
Author: Juho Ervasti <juho.ervasti@gispo.fi>
Date: Thu Dec 5 19:34:22 2024 +0200
Add unit selection for extent buffer
commit bb737f3cacb1f90c07b77b0ca776decd2a6798e5
Author: Juho Ervasti <juho.ervasti@gispo.fi>
Date: Thu Dec 5 15:48:38 2024 +0200
Disallow negative buffer
commit 13ee0bf5cfc81fa8fc95bc18448d5166b1c40414
Author: Juho Ervasti <juho.ervasti@gispo.fi>
Date: Thu Dec 5 14:44:52 2024 +0200
Apply suggestions from review
commit e17b6782fc078bc7cafdf85bc39829b989812a0b
Author: Juho Ervasti <juho.ervasti@gispo.fi>
Date: Thu Dec 5 14:31:16 2024 +0200
Add a way to change extent buffer in the GUI
commit e7a27d05c7500901ebc68fcd6f0c7160e6c0df5d
Author: Juho Ervasti <juho.ervasti@gispo.fi>
Date: Thu Dec 5 14:31:08 2024 +0200
Fix style
commit f30b50f2782216e2c31eac334fe4ebd8ae9606ae
Author: Juho Ervasti <juho.ervasti@gispo.fi>
Date: Thu Dec 5 14:28:46 2024 +0200
Add test for loading symbol with extent buffer
commit 98d20ee4797f8ea1f4c7024a6774dfb2e9cc2e04
Author: JuhoErvasti <juho.ervasti@gispo.fi>
Date: Wed Dec 4 09:33:51 2024 +0200
Add tests for rendering with extent buffer
commit e4c1598720f041754cf692bd84e1498f1a272017
Author: JuhoErvasti <juho.ervasti@gispo.fi>
Date: Wed Dec 4 09:32:49 2024 +0200
Modify feature request extent based on max extent buffer
commit d95ce12e8f0ccf3bd3ed4a09d0089e2d93618cf2
Author: JuhoErvasti <juho.ervasti@gispo.fi>
Date: Wed Dec 4 09:31:33 2024 +0200
Add tests for maximumExtentBuffer()
commit 5c49205bd2b0f3d4f016cd3a2fcd250fdba588f3
Author: JuhoErvasti <juho.ervasti@gispo.fi>
Date: Wed Dec 4 09:30:43 2024 +0200
Add maximumExtentBuffer() function to QgsFeatureRenderer
commit ccc7df59667c1bb029f8ce23c0e714c0b1f8adea
Author: JuhoErvasti <juho.ervasti@gispo.fi>
Date: Wed Dec 4 09:28:54 2024 +0200
Add extent buffer property to QgsSymbol
commit 2690802179e0eed258edf11a06aac7cf1816b69e
Author: qgis-bot <bot@qgis.org>
Date: Mon Dec 9 20:52:13 2024 +0000
auto sipify 🍺
commit 84046748d9178db6ce33367e6a78030e527118f8
Author: Damiano Lombardi <damiano@opengis.ch>
Date: Mon Dec 9 21:49:08 2024 +0100
WMS Ignore layer extent settings for default value
Allows customisation of the initial state of the "Ignore reported layer extents" checkbox
commit c763cf0cea51825ded0cee06b2163c0a36bdbeef
Author: Florian Neukirchen <99167742+florianneukirchen@users.noreply.github.com>
Date: Mon Dec 9 07:32:35 2024 +0100
Use createExpressionContext() to create context in a cleaner and safer way as suggested
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
commit 7b238cc93151520f62843b1b5f3713500e972a4b
Author: Florian Neukirchen <99167742+florianneukirchen@users.noreply.github.com>
Date: Mon Dec 9 07:25:14 2024 +0100
Remove != "" as suggested in code review
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
commit 4129a71797888335a0742d3d08317be4f45857a0
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date: Fri Dec 6 09:06:15 2024 +0000
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
commit d552495eba4934f2ae3fa8705beccfcb4c36fc6d
Author: Florian Neukirchen <mail@riannek.de>
Date: Fri Dec 6 09:15:58 2024 +0100
Optional hover text from a expression
commit 6f7afaf763730ff355116c66262be11715bc08bb
Author: hxbb00 <hxbb00@qq.com>
Date: Tue Dec 10 03:40:30 2024 +0800
Fix: ALIAS not globally visible targets with old cmake (#59752)
* Fix: ALIAS not globally visible targets with old cmake
* Compatible with cmake3.18 version
commit e9e7bc5f1abdd9e398c49ca350f95080ef8e3d53
Merge: e9138eac0d 8b447f219c
Author: Julien Cabieces <julien.cabieces@oslandia.com>
Date: Mon Dec 9 14:57:04 2024 +0100
Merge pull request #59747 from troopa81/fix_cmyk_test_qt6_8
fix(CMYK): Fix test
commit e9138eac0daaeb5658c57024f0cabafc8251c0d6
Merge: c67ca63b59 a8ca887fff
Author: …
This reverts commit 9d8f89b.
Contributor
Author
|
I am currently looking to make sure the tests work. There stills seems to be an issue with the x,y,z placeholders in vectortile urls becoming url encoded the twice, which is not supposed to happen. Also the builds should be tested with existing projects. The changes are only supposed to break projects that make use of workarounds such as double url encoding of url-parameter values. |
Contributor
|
@cioddi great to hear, I am about to leave for a vacation but I'd be very interested to test the example I posted #59143 (comment) when I get back in about 9 days, I was also curious if this PR would resolve what I suspect is the same issue with WMTS in QGIS via a gdal wmts xml file, for the purpose of that issue I only posted the wms example but when I get back I can work on a similar test with titiler and wmts. |
… of VectorTile Sources in QgsDataSurceUri
for more information, see https://pre-commit.ci
Contributor
Author
|
I found the cause for the double URL-encoding problem with z,x,y placeholders in vector-tile source URLs. QUrl and the QUrl->toString method do some encoding/decoding by default. I was able to fix it using This was not the main issue of this PR but a problem I encountered, when making sure the tests pass (as the |
…c/core/testqgshttpheaders.cpp
For different Versions of QT (5, 6) QUrlQuery produces either "url" or "url="
…T 5 and 6" This reverts commit 762ade6.
Contributor
|
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
Contributor
Author
|
I think this PR should be merged and basically all tests are passing. It appaers that one of the test setups produces "url&" and the other one "url=&" for an empty url value. Any ideas on how to fix this and commits are welcome. https://github.com/cioddi/QGIS/actions/runs/12610082558/job/35144910217?pr=1 |
Contributor
|
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
Contributor
|
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
Contributor
|
While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist. |
Collaborator
|
Hi, I have retrieved your branch and rework a bit the commits and add some tests and reponed a pull request #62446. If you still want to work on this fix, I can give you the write access to my branch. I have preserved your name in the commits I retrieved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59143 - inconsistent URL encoding/decoding with WMS sources
I will take a look at tests before marking this PR ready.
May take some time as I am currently working on a 12 year old notebook.
fixed reproduction (see #59143 for a description of the current behaviour)
https://127.0.0.1/%26%3F%26%3F/?non_standard_param=%26%3F%26%3F%26%3Fhttps://127.0.0.1/%26?%26?/QUrl url( txtUrl->text().trimmed() );non_standard_param=%26%3F%26%3F%26%3Furl.setQuery( query );https://127.0.0.1/%26%3F%26%3F/?non_standard_param=%26%3F%26%3F%26%3Fresulting in the param valuehttps%3A%2F%2F127.0.0.1%2F%2526%253F%2526%253F%2F%3Fnon_standard_param%3D%2526%253F%2526%253F%2526%253FmUri.setParam( QStringLiteral( "url" ), url );dpiMode=7&featureCount=10&tilePixelRatio=0&url=https%3A%2F%2F127.0.0.1%2F%2526%253F%2526%253F%2F%3Fnon_standard_param%3D%2526%253F%2526%253F%2526%253F. The wholeurlvalue is now URL-encoded making it now possible to retain the original URL.uri.setEncodedUri( mUri );https://127.0.0.1/%26%3F%26%3F/?non_standard_param=%26%3F%26%3F%26%3F&SERVICE=WMS&REQUEST=GetCapabilitiesQNetworkRequest request( url );