Skip to content

Gridstore deferred updates#8167

Closed
IvanPleshkov wants to merge 1 commit intodevfrom
Gridstore-deferred-updates
Closed

Gridstore deferred updates#8167
IvanPleshkov wants to merge 1 commit intodevfrom
Gridstore-deferred-updates

Conversation

@IvanPleshkov
Copy link
Contributor

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --workspace --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@timvisee
Copy link
Member

I believe #8169 is a much simpler change solving the same problem - holding a lock for a long time on the bitmask.

Gridstore already has deferred updates implemented. You're right that we might write new values into pages immediately, but we still only flush mapping changes in a deferred manner. Values can only be read through such mappings. It means that values that might be written before the flush, are only used after their mappings have been persisted as well as part of the flusher.

Based on the above I therefore don't think this adds much value, and I'm afraid the extra logic makes Gridstore over complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants