Skip to content

[gridstore] Fix draining bug by using opnums#7745

Closed
coszio wants to merge 1 commit intodevfrom
fix-gridstore-pointer-draining
Closed

[gridstore] Fix draining bug by using opnums#7745
coszio wants to merge 1 commit intodevfrom
fix-gridstore-pointer-draining

Conversation

@coszio
Copy link
Contributor

@coszio coszio commented Dec 11, 2025

Alternative to #7741

  • Move PointerUpdates to its own file, along with tests.
  • Introduce opnums for each pointer update, to make sure we remove the exact history that was persisted.
    • Disclaimer: this implementation resets the opnum count once all updates to a single ID have been persisted. This means that it might not behave well if we take two flusher copies of pending changes, and execute them out of order. But this should be already guaranteed by flushing sequence (callers).
  • Make drain_persisted to take by value, so it drops directly within the function; at the expense of removing an reinserting updates.

- Introduce opnums for updates, to make sure we remove the exact history
that was persisted
- Make `drain_persisted` to take by value, so it drops directly within
the function; at the expense of removing an reinserting updates.
@coszio coszio force-pushed the fix-gridstore-pointer-draining branch from e39f7bf to 2974cf1 Compare December 11, 2025 03:11
@coszio
Copy link
Contributor Author

coszio commented Dec 11, 2025

This is already refactored differently by #7749

@coszio coszio closed this Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant