Closed
Conversation
6 tasks
- Introduce opnums for updates, to make sure we remove the exact history that was persisted - Make `drain_persisted` to take by value, so it drops directly within the function; at the expense of removing an reinserting updates.
e39f7bf to
2974cf1
Compare
Contributor
Author
|
This is already refactored differently by #7749 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #7741
PointerUpdatesto its own file, along with tests.drain_persistedto take by value, so it drops directly within the function; at the expense of removing an reinserting updates.