Closed
Conversation
6 tasks
1ab7eef to
9252f68
Compare
575ec80 to
d482fa7
Compare
6f9a5c6 to
8299a46
Compare
Flushing the mutable ID tracker now reorders all pending changes. It puts all deletes last as it is flushed in a separate stage. Because of it, we must drop the pending deletes for a point when a new link is set.
8299a46 to
fdb75b8
Compare
Member
Author
|
Consistency has improved significantly in recent versions, especially with merging #7850. Closing this as I don't think the more complicated flushing logic will give us benefit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
Flush all segments in two stages:
This is a naive implementation that allows us to test this idea. If it works out, we can polish it further.
We've seen a variety of issues where points did go missing. Almost all of them are related to us deleting them on disk too early. Segments have a strong dependency with each other in terms of flushing order to ensure data consistency.
The rough idea of this change is to always flush deletes as very last step. This will hopefully prevent all such issues. We rely on the WAL to repair all cases where we might have partially flushed.
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?Changes to Core Features: