Closed
Conversation
Safeguard this change with a debug assertion to validate one more time that flush ordering is sound
timvisee
commented
Oct 21, 2025
Comment on lines
-65
to
-66
| // Re-sort segments for flush ordering also considering proxies, required to guarantee data consistency | ||
| segment_reads.sort_by_cached_key(|segment| segment.flush_ordering()); |
Member
Author
There was a problem hiding this comment.
For example, this is now removed because the segment holder itself already provides all segments in the desired order.
I've kept a debug assertion to prove the behavior remains the same.
6 tasks
45acc77 to
3cda23e
Compare
Member
Author
|
Superseded by #7850 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves #7381, as per #7381 (comment)
Rework the segment holder and use a single list of segments. The segments are sorted by flush ordering, then by segment ID. Ordering is guaranteed to be maintained.
This unifies ordering of segments across our code base, and removes some sorts that now became unnecessary.
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?Changes to Core Features: